From: Steven Rostedt <rostedt@goodmis.org>
To: paulmck@linux.vnet.ibm.com
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC][PATCH] ftrace: Use schedule_on_each_cpu() as a heavy synchronize_sched()
Date: Wed, 29 May 2013 09:55:28 -0400 [thread overview]
Message-ID: <1369835728.15552.69.camel@gandalf.local.home> (raw)
In-Reply-To: <20130529133315.GC6172@linux.vnet.ibm.com>
On Wed, 2013-05-29 at 06:33 -0700, Paul E. McKenney wrote:
> > Is there something a little smarter we can do? Could we use
> > on_each_cpu_cond() with a function that checks if the CPU really is
> > fully idle?
>
> One recent change that should help is making the _rcuidle variants of
> the tracing functions callable from both idle and irq. To make the
> on_each_cpu_cond() approach work, event tracing would need to switch
> from RCU (which might be preemptible RCU) to RCU-sched (whose read-side
> critical sections can pair with on_each_cpu(). I have to defer to Steven
> on whether this is a good approach.
>
Just to be clear, the issue is only with the function tracer. This has
nothing to do with trace events, as we have the _rcuidle() variants to
deal with that.
We want the function tracer to trace pretty much everything it can,
especially a complex system like RCU. Thus, I would say that the burden
goes onto the tracing facility to solve this and not prevent tracing
critical parts of RCU.
As you stated with the problem of in_irq(), there's a point where we are
in an interrupt but the in_irq() isn't set yet. And this even shows up
in function tracing:
<idle>-0 0d... 141.555326: function: smp_apic_timer_interrupt
<idle>-0 0d... 141.555327: function: native_apic_mem_write
<idle>-0 0d... 141.555327: function: exit_idle
<idle>-0 0d... 141.555327: function: irq_enter
<idle>-0 0d... 141.555327: function: rcu_irq_enter
<idle>-0 0d... 141.555328: function: idle_cpu
<idle>-0 0d.h. 141.555328: function: tick_check_idle
<idle>-0 0d.h. 141.555328: function: tick_check_oneshot_broadcast
<idle>-0 0d.h. 141.555328: function: ktime_get
Notice that we traced smp_apic_timer_interrupt, native_apic_mem_write,
exit_idle, irq_enter, and rcu_irq_enter, before rcu even was informed
that we are coming out of idle.
Then idle_cpu was also traced before the preempt_count was changed to
notify that we are in an interrupt (the 'h' in "0d.h.").
-- Steve
next prev parent reply other threads:[~2013-05-29 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 0:01 Steven Rostedt
2013-05-29 7:52 ` Peter Zijlstra
2013-05-29 13:33 ` Paul E. McKenney
2013-05-29 13:55 ` Steven Rostedt [this message]
2013-05-29 13:41 ` Steven Rostedt
2014-06-19 1:56 ` Steven Rostedt
2014-06-19 2:28 ` Paul E. McKenney
2014-06-19 7:18 ` Masami Hiramatsu
2013-05-29 8:23 ` Paul E. McKenney
2013-06-04 11:03 ` Frederic Weisbecker
2013-06-04 12:11 ` Steven Rostedt
2013-06-04 12:30 ` Frederic Weisbecker
2013-06-05 11:51 ` Peter Zijlstra
2013-06-05 13:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369835728.15552.69.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®