mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jon Arne Jørgensen" <jonarne@jonarne.no>
To: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mchehab@redhat.com,
	hans.verkuil@cisco.com, prabhakar.csengg@gmail.com,
	g.liakhovetski@gmx.de, ezequiel.garcia@free-electrons.com,
	timo.teras@iki.fi
Subject: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet
Date: Wed, 29 May 2013 22:41:16 +0200	[thread overview]
Message-ID: <1369860078-10334-2-git-send-email-jonarne@jonarne.no> (raw)
In-Reply-To: <1369860078-10334-1-git-send-email-jonarne@jonarne.no>

Change all default values in the initial setup table to match the table
in the datasheet.

Signed-off-by: Jon Arne Jørgensen <jonarne@jonarne.no>
---
 drivers/media/i2c/saa7115.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c
index d6f589a..4403679 100644
--- a/drivers/media/i2c/saa7115.c
+++ b/drivers/media/i2c/saa7115.c
@@ -223,12 +223,12 @@ static const unsigned char saa7111_init[] = {
 static const unsigned char saa7113_init[] = {
 	R_01_INC_DELAY, 0x08,
 	R_02_INPUT_CNTL_1, 0xc2,
-	R_03_INPUT_CNTL_2, 0x30,
+	R_03_INPUT_CNTL_2, 0x33,
 	R_04_INPUT_CNTL_3, 0x00,
 	R_05_INPUT_CNTL_4, 0x00,
-	R_06_H_SYNC_START, 0x89,
+	R_06_H_SYNC_START, 0xe9,
 	R_07_H_SYNC_STOP, 0x0d,
-	R_08_SYNC_CNTL, 0x88,
+	R_08_SYNC_CNTL, 0x98,
 	R_09_LUMA_CNTL, 0x01,
 	R_0A_LUMA_BRIGHT_CNTL, 0x80,
 	R_0B_LUMA_CONTRAST_CNTL, 0x47,
@@ -236,11 +236,11 @@ static const unsigned char saa7113_init[] = {
 	R_0D_CHROMA_HUE_CNTL, 0x00,
 	R_0E_CHROMA_CNTL_1, 0x01,
 	R_0F_CHROMA_GAIN_CNTL, 0x2a,
-	R_10_CHROMA_CNTL_2, 0x08,
+	R_10_CHROMA_CNTL_2, 0x00,
 	R_11_MODE_DELAY_CNTL, 0x0c,
-	R_12_RT_SIGNAL_CNTL, 0x07,
+	R_12_RT_SIGNAL_CNTL, 0x01,
 	R_13_RT_X_PORT_OUT_CNTL, 0x00,
-	R_14_ANAL_ADC_COMPAT_CNTL, 0x00,
+	R_14_ANAL_ADC_COMPAT_CNTL, 0x00,	/* RESERVED */
 	R_15_VGATE_START_FID_CHG, 0x00,
 	R_16_VGATE_STOP, 0x00,
 	R_17_MISC_VGATE_CONF_AND_MSB, 0x00,
-- 
1.8.2.3


  reply	other threads:[~2013-05-29 20:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 20:41 [RFC 0/3] saa7115: Implement i2c_board_info.platform_data Jon Arne Jørgensen
2013-05-29 20:41 ` Jon Arne Jørgensen [this message]
2013-05-30  0:35   ` [RFC 1/3] saa7115: Set saa7113 init to values from datasheet Mauro Carvalho Chehab
2013-05-30  2:19     ` Andy Walls
2013-05-30  5:21       ` Jon Arne Jørgensen
2013-05-30  5:33         ` Timo Teras
2013-05-30 19:00           ` Jon Arne Jørgensen
2013-05-31 13:08             ` Mauro Carvalho Chehab
2013-05-31 14:08               ` Timo Teras
2013-05-31 14:14               ` Jon Arne Jørgensen
2013-05-29 20:41 ` [RFC 2/3] saa7115: Remove unneeded register change for gm7113c Jon Arne Jørgensen
2013-05-29 20:41 ` [RFC 3/3] saa7115: Implement i2c_board_info.platform data Jon Arne Jørgensen
2013-05-29 20:49   ` Jon Arne Jørgensen
2013-05-30  0:42   ` Mauro Carvalho Chehab
2013-05-29 20:48 ` [RFC 0/3] saa7115: Implement i2c_board_info.platform_data Jon Arne Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369860078-10334-2-git-send-email-jonarne@jonarne.no \
    --to=jonarne@jonarne.no \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=timo.teras@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®