From: li guang <lig.fnst@cn.fujitsu.com>
To: Joe Perches <joe@perches.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff
Date: Thu, 30 May 2013 15:20:06 +0800 [thread overview]
Message-ID: <1369898406.15177.38.camel@liguang.fnst.cn.fujitsu.com> (raw)
In-Reply-To: <1369898064.22004.134.camel@joe-AO722>
在 2013-05-30四的 00:14 -0700,Joe Perches写道:
> On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
> > orderly_poweroff is expecting a bool parameter, so
> > use 'ture' instead '1'
> []
> > diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> []
> > @@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
> >
> > case EPOW_SYSTEM_HALT:
> > pr_emerg("Firmware initiated power off");
> > - orderly_poweroff(1);
> > + orderly_poweroff(ture);
> > break;
>
> Compile your patches _before_ submitting them please.
>
> "true" not "ture" here and in the commit message.
>
right, thanks!
prev parent reply other threads:[~2013-05-30 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 7:07 liguang
2013-05-30 7:14 ` Joe Perches
2013-05-30 7:20 ` li guang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369898406.15177.38.camel@liguang.fnst.cn.fujitsu.com \
--to=lig.fnst@cn.fujitsu.com \
--cc=benh@kernel.crashing.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®