From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Ortiz, Lance E" <lance.oritz@hp.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lance_ortiz@hotmail.com" <lance_ortiz@hotmail.com>,
"jiang.liu@huawei.com" <jiang.liu@huawei.com>,
"mchehab@redhat.com" <mchehab@redhat.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] aerdrv: Move cper_print_aer() call out of interrupt context
Date: Thu, 30 May 2013 09:37:08 -0400 [thread overview]
Message-ID: <1369921028.26799.4.camel@gandalf.local.home> (raw)
In-Reply-To: <20130530072849.GA20793@pd.tnic>
On Thu, 2013-05-30 at 09:28 +0200, Borislav Petkov wrote:
> On Thu, May 30, 2013 at 04:55:20AM +0000, Ortiz, Lance E wrote:
> > This TODO is a note for future clean-up and is not directly related to
> >the bug being fixed with this patch. Which lends to the argument of why
> >put the TODO in this patch? Opportunistic. I don’t think we want to
> >create a separate patch just for a TODO note.
>
> Sounds to me, this TODO item should be on your TODO list - not in kernel
> sources :-)
>
Also, that TODO sounds like there's output to userspace that can be
parsed by a userspace tool. If a tool expects the current format, it may
not be acceptable to change it later.
If the contents of this patch has nothing to do with the TODO, then
leave it out. It just confuses things.
-- Steve
next prev parent reply other threads:[~2013-05-30 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 19:03 Lance Ortiz
2013-05-29 22:48 ` Rafael J. Wysocki
2013-05-29 23:07 ` Luck, Tony
2013-05-30 4:55 ` Ortiz, Lance E
2013-05-30 7:28 ` Borislav Petkov
2013-05-30 13:37 ` Steven Rostedt [this message]
2013-05-30 14:04 ` Ortiz, Lance E
2013-05-31 7:41 ` Borislav Petkov
2013-05-30 13:58 ` Ortiz, Lance E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369921028.26799.4.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jiang.liu@huawei.com \
--cc=lance.oritz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rjw@sisk.pl \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®