From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932952Ab3E3Oi3 (ORCPT ); Thu, 30 May 2013 10:38:29 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:57819 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932636Ab3E3OiW (ORCPT ); Thu, 30 May 2013 10:38:22 -0400 Message-ID: <1369924699.1972.4.camel@dabdike.int.hansenpartnership.com> Subject: Re: [PATCH 0/5] scsi: use platform helper macro and wrapper functions From: James Bottomley To: Kefeng Wang Cc: "David S. Miller" , Thomas Bogendoerfer , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, guohanjun@huawei.com Date: Thu, 30 May 2013 07:38:19 -0700 In-Reply-To: <1369915786-2660-1-git-send-email-wangkefeng.wang@huawei.com> References: <1369915786-2660-1-git-send-email-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.8.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-05-30 at 20:09 +0800, Kefeng Wang wrote: > use module_platform_driver() and paltform{set,get}_drvdata to simpily code, > and patch 2/5 delete unnecessery drvdate set to null. > > Kefeng Wang (5): > scsi: jazz: use module_platform_driver() and > platform_{set,get}_drvdata > scsi: sun: use module_platform_driver() and platform_{set,get}_drvdata > scsi: qlogicpti: use module_platform_driver() and > platform_{set,get}_drvdata > scsi: sun3x: use module_platform_driver() and > platform_{set,get}_drvdata > scsi: sni: use module_platform_driver() and platform_{set,get}_drvdata > > drivers/scsi/jazz_esp.c | 17 +++-------------- > drivers/scsi/qlogicpti.c | 17 +++-------------- > drivers/scsi/sni_53c710.c | 17 +++-------------- > drivers/scsi/sun3x_esp.c | 16 +++------------- > drivers/scsi/sun_esp.c | 19 +++---------------- > 5 files changed, 15 insertions(+), 71 deletions(-) There doesn't seem to be much point to these patches since either idiom is fine and easily understood. We also try to touch the ancient drivers as little as possible since it can be months before anyone actually tries them out and notices that something got broken, so the rule for them is obvious bug fixes only. James