From: Steven Rostedt <rostedt@goodmis.org>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: RT <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RFC: Set irq thread to RT priority on creation
Date: Thu, 30 May 2013 10:53:22 -0400 [thread overview]
Message-ID: <1369925602.26799.5.camel@gandalf.local.home> (raw)
In-Reply-To: <1369915975-28797-1-git-send-email-meltedpianoman@gmail.com>
On Thu, 2013-05-30 at 14:12 +0200, Ivo Sieben wrote:
> kernel/irq/manage.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index fa17855..0ffe37b 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -950,6 +950,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
> */
> if (new->thread_fn && !nested) {
> struct task_struct *t;
> + static const struct sched_param param = {
> + .sched_priority = MAX_USER_RT_PRIO/2,
> + };
>
> t = kthread_create(irq_thread, new, "irq/%d-%s", irq,
> new->name);
> @@ -957,6 +960,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
> ret = PTR_ERR(t);
> goto out_mput;
> }
> +
> + sched_setscheduler(t, SCHED_FIFO, ¶m);
> +
If you are adding this here, might as well remove the
sched_set_scheduler() from irq_thread() as well. No need to do it twice.
-- Steve
> /*
> * We keep the reference to the task struct even if
> * the thread dies to avoid that the interrupt code
prev parent reply other threads:[~2013-05-30 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:12 Ivo Sieben
2013-05-30 14:07 ` Thomas Gleixner
2013-05-30 14:54 ` Steven Rostedt
2013-05-30 19:50 ` Thomas Gleixner
2013-06-03 10:12 ` [PATCH-v2] " Ivo Sieben
2013-06-03 14:45 ` Thomas Gleixner
2013-06-05 6:46 ` Ivo Sieben
2013-06-12 20:48 ` [tip:irq/core] genirq: " tip-bot for Ivo Sieben
2013-06-14 15:33 ` [PATCH-v2] " Sebastian Andrzej Siewior
2013-05-30 14:53 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369925602.26799.5.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®