mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: linux-kernel@vger.kernel.org
Cc: broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH 1/2] regmap: give users _choice_ to allow write access to debugfs
Date: Thu, 30 May 2013 21:54:01 +0530	[thread overview]
Message-ID: <1369931042-9755-1-git-send-email-vinod.koul@intel.com> (raw)

is very handy is debug kernels and should _never_ be turned On in production
mode

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 drivers/base/regmap/Kconfig          |    9 +++++++++
 drivers/base/regmap/regmap-debugfs.c |    3 +--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index f0d3054..928d6e3 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -20,3 +20,12 @@ config REGMAP_MMIO
 
 config REGMAP_IRQ
 	bool
+
+
+config REGMAP_ALLOW_WRITE_DEBUGFS
+	bool "Regmap write access to usermode"
+	default n
+	help
+	   WARNING: This allows usermode to write to hardware registers. Writing
+	   to stuff like PMICs is _never_ advised due to obvious side effects, use
+	   at very extreme caution. Is helpful for debugging
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 23b701f..7989052 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -248,8 +248,7 @@ static ssize_t regmap_map_read_file(struct file *file, char __user *user_buf,
 				   count, ppos);
 }
 
-#undef REGMAP_ALLOW_WRITE_DEBUGFS
-#ifdef REGMAP_ALLOW_WRITE_DEBUGFS
+#ifdef CONFIG_REGMAP_ALLOW_WRITE_DEBUGFS
 /*
  * This can be dangerous especially when we have clients such as
  * PMICs, therefore don't provide any real compile time configuration option
-- 
1.7.0.4


             reply	other threads:[~2013-05-30 17:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 16:24 Vinod Koul [this message]
2013-05-30 16:24 ` [PATCH 2/2] regmap: fix return of uninitialized value Vinod Koul
2013-06-01 18:52   ` Mark Brown
2013-06-01 18:49 ` [PATCH 1/2] regmap: give users _choice_ to allow write access to debugfs Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369931042-9755-1-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®