From: Julius Werner <jwerner@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dongjin Kim <tobetter@gmail.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Glass <sjg@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olofj@chromium.org>,
Vivek Gautam <gautam.vivek@samsung.com>,
Julius Werner <jwerner@chromium.org>
Subject: [PATCH 2/3] usb: misc: usb3503: Remove hardcoded disabling of ports 2 and 3
Date: Fri, 31 May 2013 18:34:51 -0700 [thread overview]
Message-ID: <1370050492-6046-3-git-send-email-jwerner@chromium.org> (raw)
In-Reply-To: <1370050492-6046-1-git-send-email-jwerner@chromium.org>
The usb3503 driver currently disables port 2 and 3 without explaination.
It doesn't make sense to do this in a mainline Linux driver that should
support all platforms which use this chip. If specific use cases really
require ports to be disabled, this should either be done through local
patches or a configurable mechanism (such as a device tree property).
Until then, let's keep all ports enabled.
Signed-off-by: Julius Werner <jwerner@chromium.org>
---
drivers/usb/misc/usb3503.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
index 73aeb87..a647a2e 100644
--- a/drivers/usb/misc/usb3503.c
+++ b/drivers/usb/misc/usb3503.c
@@ -134,14 +134,6 @@ static int usb3503_switch_mode(struct usb3503 *hub, enum usb3503_mode mode)
goto err_hubmode;
}
- /* PDS : Port2,3 Disable For Self Powered Operation */
- err = usb3503_set_bits(i2c, USB3503_PDS,
- (USB3503_PORT2 | USB3503_PORT3));
- if (err < 0) {
- dev_err(&i2c->dev, "PDS failed (%d)\n", err);
- goto err_hubmode;
- }
-
/* CFG1 : SELF_BUS_PWR -> Self-Powerd operation */
err = usb3503_set_bits(i2c, USB3503_CFG1, USB3503_SELF_BUS_PWR);
if (err < 0) {
--
1.7.12.4
next prev parent reply other threads:[~2013-06-01 1:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 1:34 [PATCH 0/3] usb: misc: usb3503: Fix up usb3503 driver Julius Werner
2013-06-01 1:34 ` [PATCH 1/3] usb: misc: usb3503: Fix up whitespace Julius Werner
2013-06-01 3:08 ` Dongjin Kim
2013-06-01 1:34 ` Julius Werner [this message]
2013-06-01 3:01 ` [PATCH 2/3] usb: misc: usb3503: Remove hardcoded disabling of ports 2 and 3 Dongjin Kim
2013-06-01 1:34 ` [PATCH 3/3] usb: misc: usb3503: Remove 100ms sleep on reset, conform to data sheet Julius Werner
2013-06-01 3:08 ` Dongjin Kim
2013-06-01 2:55 ` [PATCH 0/3] usb: misc: usb3503: Fix up usb3503 driver Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370050492-6046-3-git-send-email-jwerner@chromium.org \
--to=jwerner@chromium.org \
--cc=dianders@chromium.org \
--cc=fengguang.wu@intel.com \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=sjg@chromium.org \
--cc=tobetter@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®