mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Meyer <thomas@m3y3r.de>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86/mrst: Cocci spatch "memdup.spatch"
Date: Sat, 01 Jun 2013 11:42:50 +0200	[thread overview]
Message-ID: <1370079770.29224.13.camel@localhost.localdomain> (raw)


Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -356,10 +356,9 @@ static int __init sfi_parse_gpio(struct
 	num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
 	pentry = (struct sfi_gpio_table_entry *)sb->pentry;
 
-	gpio_table = kmalloc(num * sizeof(*pentry), GFP_KERNEL);
+	gpio_table = kmemdup(pentry, num * sizeof(*pentry), GFP_KERNEL);
 	if (!gpio_table)
 		return -1;
-	memcpy(gpio_table, pentry, num * sizeof(*pentry));
 	gpio_num_entry = num;
 
 	pr_debug("GPIO pin info:\n");
@@ -744,13 +743,12 @@ static void __init intel_scu_spi_device_
 		return;
 	}
 
-	new_dev = kzalloc(sizeof(*sdev), GFP_KERNEL);
+	new_dev = kmemdup(sdev, sizeof(*sdev), GFP_KERNEL);
 	if (!new_dev) {
 		pr_err("failed to alloc mem for delayed spi dev %s\n",
 			sdev->modalias);
 		return;
 	}
-	memcpy(new_dev, sdev, sizeof(*sdev));
 
 	spi_devs[spi_next_dev++] = new_dev;
 }
@@ -765,13 +763,12 @@ static void __init intel_scu_i2c_device_
 		return;
 	}
 
-	new_dev = kzalloc(sizeof(*idev), GFP_KERNEL);
+	new_dev = kmemdup(idev, sizeof(*idev), GFP_KERNEL);
 	if (!new_dev) {
 		pr_err("failed to alloc mem for delayed i2c dev %s\n",
 			idev->type);
 		return;
 	}
-	memcpy(new_dev, idev, sizeof(*idev));
 
 	i2c_bus[i2c_next_dev] = bus;
 	i2c_devs[i2c_next_dev++] = new_dev;



                 reply	other threads:[~2013-06-01  9:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370079770.29224.13.camel@localhost.localdomain \
    --to=thomas@m3y3r.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®