From: Yijing Wang <wangyijing@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, Hanjun Guo <guohanjun@huawei.com>,
Jiang Liu <liuj97@gmail.com>, Yijing Wang <wangyijing@huawei.com>,
Paul Zimmerman <paulz@synopsys.com>, <linux-usb@vger.kernel.org>,
<devel@driverdev.osuosl.org>
Subject: [PATCH 5/7] dwc2: remove redundant D0 power state set
Date: Mon, 3 Jun 2013 10:12:15 +0800 [thread overview]
Message-ID: <1370225535-11388-1-git-send-email-wangyijing@huawei.com> (raw)
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in dwc2_driver_probe().
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Paul Zimmerman <paulz@synopsys.com>
Cc: linux-usb@vger.kernel.org
Cc: devel@driverdev.osuosl.org
---
drivers/staging/dwc2/pci.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
index 69c65eb..6a196c2 100644
--- a/drivers/staging/dwc2/pci.c
+++ b/drivers/staging/dwc2/pci.c
@@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
if (!hsotg)
return -ENOMEM;
- pci_set_power_state(dev, PCI_D0);
-
hsotg->dev = &dev->dev;
hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
if (!hsotg->regs)
--
1.7.1
next reply other threads:[~2013-06-03 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 2:12 Yijing Wang [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-30 10:24 Yijing Wang
2013-05-30 18:18 ` Paul Zimmerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370225535-11388-1-git-send-email-wangyijing@huawei.com \
--to=wangyijing@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=paulz@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®