mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <myungjoo.ham@samsung.com>, <cw00.choi@samsung.com>,
	<balbi@ti.com>, <devicetree-discuss@lists.ozlabs.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>
Cc: <kishon@ti.com>, <grant.likely@linaro.org>,
	<rob.herring@calxeda.com>, <rob@landley.net>,
	<gregkh@linuxfoundation.org>, <benoit.cousson@linaro.org>,
	<anish198519851985@gmail.com>, <pmeerw@pmeerw.net>
Subject: [PATCH 4/5] usb: dwc3: omap: improve error handling of dwc3_omap_probe
Date: Mon, 3 Jun 2013 21:43:39 +0530	[thread overview]
Message-ID: <1370276020-17446-5-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1370276020-17446-1-git-send-email-kishon@ti.com>

Improved the error handling of dwc3_omap_probe so that on error
conditions dwc3_omap is left in the original state.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/usb/dwc3/dwc3-omap.c |   17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 34638b9..f8f76e6 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -347,7 +347,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
 	ret = pm_runtime_get_sync(dev);
 	if (ret < 0) {
 		dev_err(dev, "get_sync failed with err %d\n", ret);
-		return ret;
+		goto err0;
 	}
 
 	reg = dwc3_omap_readl(omap->base, USBOTGSS_UTMI_OTG_STATUS);
@@ -376,7 +376,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(dev, "failed to request IRQ #%d --> %d\n",
 				omap->irq, ret);
-		return ret;
+		goto err1;
 	}
 
 	dwc3_omap_enable_irqs(omap);
@@ -384,10 +384,21 @@ static int dwc3_omap_probe(struct platform_device *pdev)
 	ret = of_platform_populate(node, NULL, NULL, dev);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to create dwc3 core\n");
-		return ret;
+		goto err2;
 	}
 
 	return 0;
+
+err2:
+	dwc3_omap_disable_irqs(omap);
+
+err1:
+	pm_runtime_put_sync(dev);
+
+err0:
+	pm_runtime_disable(dev);
+
+	return ret;
 }
 
 static int dwc3_omap_remove(struct platform_device *pdev)
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-03 16:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 16:13 [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework Kishon Vijay Abraham I
2013-06-03 16:13 ` [PATCH 1/5] extcon: Add an API to get extcon device from dt node Kishon Vijay Abraham I
2013-06-12  1:28   ` Chanwoo Choi
2013-06-12  1:39   ` [PATCH] " Chanwoo Choi
2013-06-12  5:16     ` anish singh
2013-06-12  6:55     ` Kishon Vijay Abraham I
2013-06-14  5:08       ` Chanwoo Choi
2013-06-14  7:15   ` [PATCH v2] " Chanwoo Choi
2013-06-14  8:36     ` Kishon Vijay Abraham I
2013-06-14  8:51       ` Chanwoo Choi
2013-06-19  5:26   ` [PATCH v3] " Chanwoo Choi
2013-06-03 16:13 ` [PATCH 2/5] extcon: Kconfig: Make extcon config type as bool Kishon Vijay Abraham I
2013-06-03 16:13 ` [PATCH 3/5] extcon: add EXPORT_SYMBOL_GPL for exported functions Kishon Vijay Abraham I
2013-06-03 16:13 ` Kishon Vijay Abraham I [this message]
2013-06-03 16:13 ` [v3 PATCH 5/5] usb: dwc3: use extcon fwrk to receive connect/disconnect Kishon Vijay Abraham I
2013-06-14 13:10   ` [PATCH v4] " Kishon Vijay Abraham I
2013-06-17  4:09     ` Chanwoo Choi
2013-06-20  8:54       ` Kishon Vijay Abraham I
2013-06-21 11:58     ` [PATCH v5] " Kishon Vijay Abraham I
2013-06-24 11:12       ` Chanwoo Choi
2013-06-04 14:23 ` [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework Ruchika Kharwar
2013-06-05  4:49   ` Kishon Vijay Abraham I
2013-06-12  0:54 ` Chanwoo Choi
2013-06-12  0:59 ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370276020-17446-5-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=anish198519851985@gmail.com \
    --cc=balbi@ti.com \
    --cc=benoit.cousson@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=pmeerw@pmeerw.net \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome