From: Marcus Overhagen <marcus.overhagen@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] staging: rts5139: Use correct USB transfer interval to fix syslog spamming
Date: Mon, 3 Jun 2013 20:14:02 +0200 [thread overview]
Message-ID: <1370283242-24434-3-git-send-email-marcus.overhagen@gmail.com> (raw)
In-Reply-To: <1370283242-24434-1-git-send-email-marcus.overhagen@gmail.com>
Using correct transfer interval as specified by the USB endpoint
when doing the interrupt transfer fixes the warning printed by
xhci USB core on every transfer that resulted in spamming
"xhci_queue_intr_tx: 74 callbacks suppressed" to syslog
every 5 seconds.
Signed-off-by: Marcus Overhagen <marcus.overhagen@gmail.com>
---
drivers/staging/rts5139/rts51x_transport.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x_transport.c b/drivers/staging/rts5139/rts51x_transport.c
index c573618..c172f4a 100644
--- a/drivers/staging/rts5139/rts51x_transport.c
+++ b/drivers/staging/rts5139/rts51x_transport.c
@@ -635,10 +635,10 @@ int rts51x_get_epc_status(struct rts51x_chip *chip, u16 *status)
ep = chip->usb->pusb_dev->ep_in[usb_pipeendpoint(pipe)];
/* fill and submit the URB */
- /* We set interval to 1 here, so the polling interval is controlled
- * by our polling thread */
+ /* Set interval to 10 here to match the endpoint descriptor,
+ * the polling interval is controlled by the polling thread */
usb_fill_int_urb(chip->usb->intr_urb, chip->usb->pusb_dev, pipe,
- status, 2, urb_done_completion, &urb_done, 1);
+ status, 2, urb_done_completion, &urb_done, 10);
result = rts51x_msg_common(chip, chip->usb->intr_urb, 100);
--
1.8.1.2
next prev parent reply other threads:[~2013-06-03 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 18:14 [PATCH 0/2] staging: rts5139: Fix SD card reader for Samsung NP730U3E Marcus Overhagen
2013-06-03 18:14 ` [PATCH 1/2] staging: rts5139: Fix SD card detection on Samsung NP730U3E Ultrabook Marcus Overhagen
2013-06-03 18:14 ` Marcus Overhagen [this message]
2013-09-17 9:56 ` [PATCH 2/2] staging: rts5139: Use correct USB transfer interval to fix syslog spamming Lutz Vieweg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370283242-24434-3-git-send-email-marcus.overhagen@gmail.com \
--to=marcus.overhagen@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®