mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <jbottomley@parallels.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"ohering@suse.com" <ohering@suse.com>,
	"hch@infradead.org" <hch@infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/5] Drivers: scsi: storvsc: Make the scsi timeout a module parameter
Date: Mon, 3 Jun 2013 23:03:01 +0000	[thread overview]
Message-ID: <1370300581.2013.14.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1370301688-27286-1-git-send-email-kys@microsoft.com>

On Mon, 2013-06-03 at 16:21 -0700, K. Y. Srinivasan wrote:
> The standard scsi timeout is not appropriate in some of the environments where
> Hyper-V is deployed. Set this timeout appropriately for all devices managed
> by this driver. Further make this a module parameter.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
>  drivers/scsi/storvsc_drv.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 16a3a0c..8d29a95 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -221,6 +221,13 @@ static int storvsc_ringbuffer_size = (20 * PAGE_SIZE);
>  module_param(storvsc_ringbuffer_size, int, S_IRUGO);
>  MODULE_PARM_DESC(storvsc_ringbuffer_size, "Ring buffer size (bytes)");
>  
> +/*
> + * Timeout in seconds for all devices managed by this driver.
> + */
> +static int storvsc_timeout = 180;
> +module_param(storvsc_timeout, uint, (S_IRUGO | S_IWUSR));
> +MODULE_PARM_DESC(storvsc_timeout, "Device timeout (seconds)");
> +
>  #define STORVSC_MAX_IO_REQUESTS				128
>  
>  /*
> @@ -1204,6 +1211,8 @@ static int storvsc_device_configure(struct scsi_device *sdevice)
>  
>  	blk_queue_bounce_limit(sdevice->request_queue, BLK_BOUNCE_ANY);
>  
> +	blk_queue_rq_timeout(sdevice->request_queue, (storvsc_timeout * HZ));

Why does this need to be a module parameter?  It's already a sysfs one
in the scsi_device class?  Three minutes is also a bit large.  The
default is 30s with huge cache arrays recommending upping this to
60s ... you're three times this.

James


  reply	other threads:[~2013-06-03 23:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 23:18 [PATCH V2 0/5] Drivers: scsi: storvsc K. Y. Srinivasan
2013-06-03 23:21 ` [PATCH 1/5] Drivers: scsi: storvsc: Make the scsi timeout a module parameter K. Y. Srinivasan
2013-06-03 23:03   ` James Bottomley [this message]
2013-06-03 23:25     ` KY Srinivasan
2013-06-03 23:47       ` James Bottomley
2013-06-04  0:21         ` KY Srinivasan
2013-06-03 23:21   ` [PATCH 2/5] Drivers: scsi: storvsc: Update the storage protocol to win8 level K. Y. Srinivasan
2013-06-03 23:21   ` [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support K. Y. Srinivasan
2013-06-03 23:21   ` [PATCH 4/5] Drivers: scsi: storvsc: Support FC devices K. Y. Srinivasan
2013-06-03 23:21   ` [PATCH 5/5] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS K. Y. Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370300581.2013.14.camel@dabdike.int.hansenpartnership.com \
    --to=jbottomley@parallels.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ohering@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®