From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>
Subject: [PATCH 15/16] perf util: No need to call read_trace_init() in tracing_data_header()
Date: Tue, 4 Jun 2013 14:20:30 +0900 [thread overview]
Message-ID: <1370323231-14022-16-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1370323231-14022-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
It's useless to call the read_trace_init() function at this time as we
don't need a returned pevent and it makes me confusing. :)
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/trace-event-info.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index 9648175e2a1c..e85cbcf298f3 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -520,8 +520,6 @@ static int tracing_data_header(void)
else
buf[0] = 0;
- read_trace_init(buf[0], buf[0]);
-
if (write(output_fd, buf, 1) != 1)
return -1;
--
1.7.11.7
next prev parent reply other threads:[~2013-06-04 5:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 5:20 [PATCHSET 00/16] perf tools: Cleanups on tracepoint handling Namhyung Kim
2013-06-04 5:20 ` [PATCH 01/16] tools lib traceevent: Remove unused install targets Namhyung Kim
2013-07-19 7:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 02/16] tools lib traceevent: Get rid of unused gui target Namhyung Kim
2013-07-19 7:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 03/16] tools lib traceevent: Add const qualifier to string arguments Namhyung Kim
2013-07-19 7:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 04/16] tools lib traceevent: Add trace_seq_reset() Namhyung Kim
2013-07-19 7:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 05/16] tools lib traceevent: Add page_size field to pevent Namhyung Kim
2013-07-19 7:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 06/16] tools lib traceevent: Port kbuffer parser routines Namhyung Kim
2013-07-19 7:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 07/16] perf util: Save page size in a trace file to pevent Namhyung Kim
2013-07-19 7:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 08/16] perf util: Save long size of traced system Namhyung Kim
2013-07-19 7:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 09/16] perf util: Make file/host_bigendian variable local Namhyung Kim
2013-07-19 7:46 ` [tip:perf/core] perf util: Make file/ host_bigendian " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 10/16] perf util: Skip reading header_event file Namhyung Kim
2013-07-19 7:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 11/16] perf util: Parse header_page to get proper long size Namhyung Kim
2013-06-06 15:37 ` Jiri Olsa
2013-06-07 8:56 ` Namhyung Kim
2013-06-07 9:01 ` Jiri Olsa
2013-07-19 7:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 12/16] perf util: Get rid of unused header_page_* variables Namhyung Kim
2013-07-19 7:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 13/16] perf util: Move latency_format variable to builtin-script.c Namhyung Kim
2013-07-19 7:47 ` [tip:perf/core] perf script: Adopt latency_format variable tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 14/16] perf util: Rename read_*() functions in trace-event-info.c Namhyung Kim
2013-07-19 7:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04 5:20 ` Namhyung Kim [this message]
2013-07-19 7:47 ` [tip:perf/core] perf util: No need to call read_trace_init() in tracing_data_header() tip-bot for Namhyung Kim
2013-06-04 5:20 ` [PATCH 16/16] perf util: Remove unused enum and macro in trace-event.h Namhyung Kim
2013-07-19 7:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-24 5:38 ` [PATCHSET 00/16] perf tools: Cleanups on tracepoint handling Namhyung Kim
2013-07-04 8:39 ` Namhyung Kim
2013-07-05 13:16 ` Arnaldo Carvalho de Melo
2013-07-05 13:35 ` Namhyung Kim
2013-07-05 14:57 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370323231-14022-16-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®