From: Joe Perches <joe@perches.com>
To: Aldo Iljazi <neonsync1@gmail.com>
Cc: gregh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch errors and warnings
Date: Wed, 05 Jun 2013 16:14:03 -0700 [thread overview]
Message-ID: <1370474043.2253.11.camel@joe-AO722> (raw)
In-Reply-To: <1370463827-6881-1-git-send-email-neonsync1@gmail.com>
On Wed, 2013-06-05 at 23:23 +0300, Aldo Iljazi wrote:
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
[]
> @@ -893,13 +892,13 @@ static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
> if (obj->ops->timeline_value_str) {
> char value[64];
> obj->ops->timeline_value_str(obj, value, sizeof(value));
> - seq_printf(s, ": %s", value);
> + seq_puts(s, ": %s", value);
This is wrong and shouldn't compile without warning.
Is this an over aggressive conversion or did checkpatch
really complain on this line?
prev parent reply other threads:[~2013-06-05 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 20:23 Aldo Iljazi
2013-06-05 20:34 ` Greg KH
2013-06-05 23:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370474043.2253.11.camel@joe-AO722 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neonsync1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®