From: Matthew Garrett <matthew.garrett@nebula.com>
To: joeyli <jlee@suse.com>
Cc: Matt Fleming <matt@console-pimps.org>,
"Fleming, Matt" <matt.fleming@intel.com>,
"rja@sgi.com" <rja@sgi.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"bp@alien8.de" <bp@alien8.de>,
"jkosina@suse.cz" <jkosina@suse.cz>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@linux.intel.com" <hpa@linux.intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"oneukum@suse.de" <oneukum@suse.de>
Subject: Re: [PATCH] Modify UEFI anti-bricking code
Date: Thu, 6 Jun 2013 05:42:01 +0000 [thread overview]
Message-ID: <1370497321.6315.44.camel@x230.lan> (raw)
In-Reply-To: <1370495110.6523.35.camel@linux-s257.site>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 572 bytes --]
On Thu, 2013-06-06 at 13:05 +0800, joeyli wrote:
> + if (!(attributes & EFI_VARIABLE_NON_VOLATILE))
> + return EFI_OUT_OF_RESOURCES;
I'd move this up to the top of the function, and just return 0 - there's
no risk of the firmware causing problems if it's a volatile variable, so
we should probably just pass it down to the firmware and return an error
from there.
--
Matthew Garrett | mjg59@srcf.ucam.org
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2013-06-06 5:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 20:06 Matthew Garrett
2013-06-02 15:48 ` Russ Anderson
2013-06-03 12:17 ` Matt Fleming
2013-06-03 14:58 ` Matthew Garrett
2013-06-03 16:13 ` joeyli
2013-06-03 16:31 ` Matthew Garrett
2013-06-04 3:35 ` joeyli
2013-06-05 14:49 ` Fleming, Matt
2013-06-05 14:53 ` Matthew Garrett
2013-06-05 15:59 ` Matt Fleming
2013-06-05 16:08 ` Matthew Garrett
2013-06-05 19:59 ` Matt Fleming
2013-06-06 2:24 ` joeyli
2013-06-05 20:19 ` H. Peter Anvin
2013-06-06 5:05 ` joeyli
2013-06-06 5:41 ` joeyli
2013-06-06 5:42 ` Matthew Garrett [this message]
2013-06-06 7:40 ` joeyli
2013-06-06 9:25 ` Matt Fleming
2013-06-06 14:48 ` Russ Anderson
2013-06-06 15:00 ` Matt Fleming
2013-06-06 15:28 ` Russ Anderson
2013-06-10 18:54 ` Russ Anderson
2013-06-04 5:29 ` Lingzhu Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370497321.6315.44.camel@x230.lan \
--to=matthew.garrett@nebula.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mingo@kernel.org \
--cc=oneukum@suse.de \
--cc=rja@sgi.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®