From: Eric Dumazet <eric.dumazet@gmail.com>
To: greearb@candelatech.com
Cc: linux-kernel@vger.kernel.org, tj@kernel.org
Subject: Re: [PATCH v2] Fix lockup related to stop_machine being stuck in __do_softirq.
Date: Thu, 06 Jun 2013 09:14:12 -0700 [thread overview]
Message-ID: <1370535252.24311.357.camel@edumazet-glaptop> (raw)
In-Reply-To: <1370535006-3467-1-git-send-email-greearb@candelatech.com>
On Thu, 2013-06-06 at 09:10 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> The stop machine logic can lock up if all but one of
> the migration threads make it through the disable-irq
> step and the one remaining thread gets stuck in
> __do_softirq. The reason __do_softirq can hang is
> that it has a bail-out based on jiffies timeout, but
> in the lockup case, jiffies itself is not incremented.
...
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2: Fix comments and reformat conditional per suggestions.
>
Acked-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2013-06-06 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 16:10 greearb
2013-06-06 16:14 ` Eric Dumazet [this message]
2013-06-06 20:48 ` Tejun Heo
2013-06-06 21:33 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370535252.24311.357.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®