mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@gmail.com>
To: rostedt@goodmis.org, fweisbec@gmail.com, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, juri.lelli@gmail.com
Subject: [PATCH 0/3] ftrace: fix stddev calculation and add a test for it
Date: Tue, 11 Jun 2013 11:08:45 +0200	[thread overview]
Message-ID: <1370941728-15456-1-git-send-email-juri.lelli@gmail.com> (raw)

While profiling kernel functions via ftrace I noticed values of s^2 that
seemed odd. I implemented a test to verify correctness of averages and
s^2 calculations and proved the latter to be wrong. Then I fixed them up.

The first patch refactors function_stat_show() code a bit in order to be
able to implement the test (second patch). Third patch fixes up s^2
calculation (applying Welford's method).

Juri Lelli (3):
  ftrace: refactor basis statistics calculation code
  ftrace: test basic statistics calculation
  ftrace: fix stddev calculation

 kernel/trace/ftrace.c         |   50 ++++++++++++++--------------
 kernel/trace/trace.h          |   16 +++++++++
 kernel/trace/trace_selftest.c |   72 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 114 insertions(+), 24 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2013-06-11  9:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11  9:08 Juri Lelli [this message]
2013-06-11  9:08 ` [PATCH 1/3] ftrace: refactor basis statistics calculation code Juri Lelli
2013-06-11  9:08 ` [PATCH 2/3] ftrace: test basic statistics calculation Juri Lelli
2013-06-12  0:00   ` Steven Rostedt
2013-06-11  9:08 ` [PATCH 3/3] ftrace: fix stddev calculation Juri Lelli
2013-06-12  3:09   ` Steven Rostedt
2013-06-12  9:34     ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370941728-15456-1-git-send-email-juri.lelli@gmail.com \
    --to=juri.lelli@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®