From: Qiao Zhou <zhouqiao@marvell.com>
To: <djbw@fb.com>, <vinod.koul@intel.com>, <zhangfei.gao@gmail.com>,
<linux-kernel@vger.kernel.org>
Cc: Qiao Zhou <zhouqiao@marvell.com>
Subject: [PATCH V2] dma: mmp_tdma: disable irq when disabling dma channel
Date: Sat, 15 Jun 2013 12:51:48 +0800 [thread overview]
Message-ID: <1371271908-29596-2-git-send-email-zhouqiao@marvell.com> (raw)
In-Reply-To: <1371271908-29596-1-git-send-email-zhouqiao@marvell.com>
mask dma irq when disabling dma channel, so that interrupt status
will not be set and interrupt won't come again.
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
drivers/dma/mmp_tdma.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index 43d5a6c..9b93665 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -154,6 +154,10 @@ static void mmp_tdma_disable_chan(struct mmp_tdma_chan *tdmac)
{
writel(readl(tdmac->reg_base + TDCR) & ~TDCR_CHANEN,
tdmac->reg_base + TDCR);
+
+ /* disable irq */
+ writel(0, tdmac->reg_base + TDIMR);
+
tdmac->status = DMA_SUCCESS;
}
--
1.7.0.4
next prev parent reply other threads:[~2013-06-15 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 4:51 Qiao Zhou
2013-06-15 4:51 ` Qiao Zhou [this message]
2013-06-15 7:52 ` zhangfei gao
2013-06-21 8:52 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371271908-29596-2-git-send-email-zhouqiao@marvell.com \
--to=zhouqiao@marvell.com \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®