From: Joe Perches <joe@perches.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Mischa Jonker <Mischa.Jonker@synopsys.com>,
Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH v4] ethernet/arc/arc_emac - Add new driver
Date: Sun, 16 Jun 2013 00:41:31 -0700 [thread overview]
Message-ID: <1371368491.2116.0.camel@joe-AO722> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE643F5E7779@DE02WEMBXB.internal.synopsys.com>
On Sat, 2013-06-15 at 20:47 +0000, Alexey Brodkin wrote:
> On 06/16/2013 12:37 AM, Joe Perches wrote:
> > On Sun, 2013-06-16 at 00:20 +0400, Alexey Brodkin wrote:
[]
> >> +static int arc_emac_rx(struct net_device *ndev, int budget)
> > []
> >> + /* Prepare the BD for next cycle */
> >> + rx_buff->skb = netdev_alloc_skb_ip_align(ndev, buflen);
> >> + if (unlikely(!rx_buff->skb)) {
> >> + if (net_ratelimit())
> >> + netdev_err(ndev, "cannot allocate skb\n");
> >
> > Unnecessary OOM message, might as well remove it.
> > rx_dropped gives the same info.
>
> With all those error messages I wanted to make life easier (especially
> for me) if errors appear. User will immediately know where problem
> happened. Indeed "rx_dropped" (when it is used only once in driver) may
> show where issue happened, but if later at some point "rx_dropped" will
> be incremented in other locations then user won't understand immediately
> where error happened.
Alloc errors emit a dump_stack() already so this is redundant.
next prev parent reply other threads:[~2013-06-16 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 20:20 Alexey Brodkin
2013-06-15 20:37 ` Joe Perches
2013-06-15 20:47 ` Alexey Brodkin
2013-06-16 7:41 ` Joe Perches [this message]
2013-06-17 9:03 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371368491.2116.0.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Mischa.Jonker@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rob.herring@calxeda.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®