From: Paul Bolle <pebolle@tiscali.nl>
To: Dan Williams <djbw@fb.com>, Vinod Koul <vinod.koul@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ioatdma: silence GCC warnings
Date: Mon, 17 Jun 2013 12:35:15 +0200 [thread overview]
Message-ID: <1371465315.26299.17.camel@x61.thuisdomein> (raw)
Building dma_v3.o triggers two GCC warnings:
drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’:
drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]
drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]
These warnings are caused by pq16_set_src(). It uses "int idx" as an
index to an eight element array. Changing "idx" to unsigned int silences
these warnings. Apparently GCC can then determine that "idx" will never
be negative.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Compile tested only.
1) These warning were introduced in v3.10-rc1. That must have been
through commit 7727eaa449 ("ioatdma: Adding support for 16 src PQ ops
and super extended descriptors").
drivers/dma/ioat/dma_v3.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
index ca6ea9b..b5102da 100644
--- a/drivers/dma/ioat/dma_v3.c
+++ b/drivers/dma/ioat/dma_v3.c
@@ -251,7 +251,7 @@ static bool is_bwd_noraid(struct pci_dev *pdev)
}
static void pq16_set_src(struct ioat_raw_descriptor *desc[3],
- dma_addr_t addr, u32 offset, u8 coef, int idx)
+ dma_addr_t addr, u32 offset, u8 coef, unsigned int idx)
{
struct ioat_pq_descriptor *pq = (struct ioat_pq_descriptor *)desc[0];
struct ioat_pq16a_descriptor *pq16 =
@@ -1180,7 +1180,7 @@ __ioat3_prep_pq16_lock(struct dma_chan *c, enum sum_check_flags *result,
struct ioat_pq_descriptor *pq;
u32 offset = 0;
u8 op;
- int i, s, idx, num_descs;
+ int i, idx, num_descs;
/* this function only handles src_cnt 9 - 16 */
BUG_ON(src_cnt < 9);
@@ -1206,6 +1206,7 @@ __ioat3_prep_pq16_lock(struct dma_chan *c, enum sum_check_flags *result,
do {
struct ioat_raw_descriptor *descs[4];
size_t xfer_size = min_t(size_t, len, 1 << ioat->xfercap_log);
+ unsigned int s;
desc = ioat2_get_ring_ent(ioat, idx + i);
pq = desc->pq;
--
1.8.1.4
next reply other threads:[~2013-06-17 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 10:35 Paul Bolle [this message]
2013-07-15 9:50 ` Paul Bolle
2013-07-15 9:40 ` Vinod Koul
2013-07-17 22:39 ` Dan Williams
2013-07-18 11:42 ` Paul Bolle
2013-07-20 18:05 ` [PATCH v2] " Paul Bolle
2013-07-22 15:46 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371465315.26299.17.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®