mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenz Haspel <lorenz@badgers.com>
To: devel@linuxdriverproject.org
Cc: gregkh@linuxfoundation.org, puff65537@bansheeslibrary.com,
	viro@zeniv.linux.org.uk,
	michael.banken@mathe.stud.uni-erlangen.de,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	linux-kernel@i4.informatik.uni-erlangen.de,
	Lorenz Haspel <lorenz@badgers.com>
Subject: [PATCH 4/5] silicom: checkpatch: trailing statements
Date: Mon, 17 Jun 2013 16:20:16 +0200	[thread overview]
Message-ID: <1371478817-28357-4-git-send-email-lorenz@badgers.com> (raw)
In-Reply-To: <1371478817-28357-1-git-send-email-lorenz@badgers.com>

fixed checkpatch error:
trailing statements that should be on next line

Signed-off-by: Michael Banken <michael.banken@mathe.stud.uni-erlangen.de>
Signed-off-by: Lorenz Haspel <lorenz@badgers.com>
---
 drivers/staging/silicom/bpctl_mod.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
index 78570dd..85aa900 100644
--- a/drivers/staging/silicom/bpctl_mod.c
+++ b/drivers/staging/silicom/bpctl_mod.c
@@ -165,7 +165,9 @@ static int bp_device_event(struct notifier_block *unused,
 			memcpy(&cbuf, drvinfo.bus_info, 32);
 			buf = &cbuf[0];
 
-			while (*buf++ != ':') ;
+			while (*buf != ':')
+				buf++;
+			buf++;
 			for (i = 0; i < 10; i++, buf++) {
 				if (*buf == ':')
 					break;
@@ -2158,12 +2160,14 @@ static void bp75_release_phy(bpctl_dev_t *pbpctl_dev)
 {
 	u16 mask = BPCTLI_SWFW_PHY0_SM;
 	u32 swfw_sync;
+	s32 ret_val;
 
 	if ((pbpctl_dev->func == 1) || (pbpctl_dev->func == 3))
 		mask = BPCTLI_SWFW_PHY1_SM;
 
-	while (bp75_get_hw_semaphore_generic(pbpctl_dev) != 0) ;
-	/* Empty */
+	do
+		ret_val = bp75_get_hw_semaphore_generic(pbpctl_dev);
+	while (ret_val != 0);
 
 	swfw_sync = BPCTL_READ_REG(pbpctl_dev, SW_FW_SYNC);
 	swfw_sync &= ~mask;
@@ -5368,7 +5372,9 @@ static void if_scan_init(void)
 		memcpy(&cbuf, drvinfo.bus_info, 32);
 		buf = &cbuf[0];
 
-		while (*buf++ != ':') ;
+		while (*buf != ':')
+			buf++;
+		buf++;
 		for (i = 0; i < 10; i++, buf++) {
 			if (*buf == ':')
 				break;
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-17 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 14:20 [PATCH 1/5] silicom: checkpatch: assignments in if conditions Lorenz Haspel
2013-06-17 14:20 ` [PATCH 2/5] silicom: checkpatch: fixed whitespace errors Lorenz Haspel
2013-06-17 15:20   ` Dan Carpenter
2013-06-17 15:34     ` Dan Carpenter
2013-06-17 14:20 ` [PATCH 3/5] silicom: checkpatch: explicit initialised statics Lorenz Haspel
2013-06-17 14:20 ` Lorenz Haspel [this message]
2013-06-17 15:28   ` [PATCH 4/5] silicom: checkpatch: trailing statements Dan Carpenter
2013-06-17 14:20 ` [PATCH 5/5] solicom: checkpatch: added parenthesis to macros Lorenz Haspel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371478817-28357-4-git-send-email-lorenz@badgers.com \
    --to=lorenz@badgers.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@i4.informatik.uni-erlangen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.banken@mathe.stud.uni-erlangen.de \
    --cc=puff65537@bansheeslibrary.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome