mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robin van der Gracht <robin@protonic.nl>
To: thierry.reding@avionic-design.de
Cc: linux-kernel@vger.kernel.org, shawn.guo@linaro.org,
	Robin van der Gracht <robin@protonic.nl>
Subject: [PATCH] pwm: pwm-mxs: Apply configuration before disabling PWM.
Date: Wed, 19 Jun 2013 13:51:26 +0200	[thread overview]
Message-ID: <1371642686-10300-1-git-send-email-robin@protonic.nl> (raw)

When disabling the pwm, the output state locks at its current state.
We have to be sure the last configuration applied. Which in most
cases sets duty cycle to 0%. To prevent the pwm from taking on
100% duty cycle when disabled during a high state.

Configuration applies at the beginning of a new output period.

Signed-off-by: Robin van der Gracht <robin@protonic.nl>
---
 drivers/pwm/pwm-mxs.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index 3febddd..4ddc063 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -21,6 +21,7 @@
 #include <linux/pwm.h>
 #include <linux/slab.h>
 #include <linux/stmp_device.h>
+#include <linux/delay.h>
 
 #define SET	0x4
 #define CLR	0x8
@@ -40,6 +41,7 @@ struct mxs_pwm_chip {
 	struct pwm_chip chip;
 	struct clk *clk;
 	void __iomem *base;
+	unsigned long period_ns;
 };
 
 #define to_mxs_pwm_chip(_chip) container_of(_chip, struct mxs_pwm_chip, chip)
@@ -92,6 +94,7 @@ static int mxs_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 	if (!test_bit(PWMF_ENABLED, &pwm->flags))
 		clk_disable_unprepare(mxs->clk);
 
+	mxs->period_ns = period_ns;
 	return 0;
 }
 
@@ -113,6 +116,11 @@ static void mxs_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 {
 	struct mxs_pwm_chip *mxs = to_mxs_pwm_chip(chip);
 
+	/*
+	 * Ensure latest configuration applied.
+	 */
+	ndelay(mxs->period_ns);
+
 	writel(1 << pwm->hwpwm, mxs->base + PWM_CTRL + CLR);
 
 	clk_disable_unprepare(mxs->clk);
-- 
1.7.9.5


             reply	other threads:[~2013-06-19 12:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 11:51 Robin van der Gracht [this message]
2013-06-21 10:02 ` Thierry Reding
2013-06-26  6:52   ` Robin van der Gracht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371642686-10300-1-git-send-email-robin@protonic.nl \
    --to=robin@protonic.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®