From: Eric Dumazet <eric.dumazet@gmail.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/timer.c: using spin_lock_irqsave instead of spin_lock + local_irq_save, especially when CONFIG_LOCKDEP not defined
Date: Thu, 20 Jun 2013 02:12:54 -0700 [thread overview]
Message-ID: <1371719574.3252.397.camel@edumazet-glaptop> (raw)
In-Reply-To: <51C2BF3C.8020804@asianux.com>
On Thu, 2013-06-20 at 16:37 +0800, Chen Gang wrote:
> spin_lock_irqsave(&lock, flags);
>
> is not semantically the same as
>
> local_irq_save(flags);
> spin_lock(&lock);
>
> It depend on the spin_lock_irqsave() implementation, if the parameters
> has no relation ship with each other, semantically the same.
Of course all implementations must respect the blocks are
totally the same.
Arguing about this is plain silly.
If you found a buggy implementation, please fix it.
prev parent reply other threads:[~2013-06-20 9:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 2:59 Chen Gang
2013-06-19 8:41 ` Thomas Gleixner
2013-06-19 9:42 ` Chen Gang
2013-06-19 9:59 ` Thomas Gleixner
2013-06-19 10:07 ` Chen Gang
2013-06-19 10:49 ` Thomas Gleixner
2013-06-20 4:14 ` Chen Gang
2013-06-20 7:36 ` Thomas Gleixner
2013-06-20 8:42 ` Chen Gang
2013-06-20 9:02 ` Thomas Gleixner
2013-06-20 10:31 ` Chen Gang
2013-06-19 10:21 ` Chen Gang
2013-06-19 10:53 ` Thomas Gleixner
2013-06-20 8:37 ` Chen Gang
2013-06-20 9:07 ` Thomas Gleixner
2013-06-20 9:53 ` Chen Gang
2013-06-20 10:42 ` Thomas Gleixner
2013-06-20 10:59 ` Chen Gang
2013-06-20 9:12 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371719574.3252.397.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®