From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755604AbbHQQch (ORCPT ); Mon, 17 Aug 2015 12:32:37 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:46994 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbbHQQcf (ORCPT ); Mon, 17 Aug 2015 12:32:35 -0400 X-AuditID: cbfee61b-f79706d000001b96-76-55d20ca0842b From: Bartlomiej Zolnierkiewicz To: Sergei Shtylyov Cc: linux-ia64@vger.kernel.org, Tony Luck , Fenghua Yu , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers Date: Mon, 17 Aug 2015 18:31:03 +0200 Message-id: <13721070.NVYmjefytC@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <55D2097A.7090203@cogentembedded.com> References: <1439826388-31456-1-git-send-email-b.zolnierkie@samsung.com> <1439826388-31456-2-git-send-email-b.zolnierkie@samsung.com> <55D2097A.7090203@cogentembedded.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t9jAd0FPJdCDf7NNbNom+Zo8aHjHavF sR2PmCwu75rDZnFm1S12izcX7rE4sHk8mPqfyWPxnpdMHp83yQUwR3HZpKTmZJalFunbJXBl fF97hL3gIX/F0vsbWRoYT/N0MXJySAiYSKy4PZ0dwhaTuHBvPVsXIxeHkMBSRomnK0ESIM5X RokH23exgFSxCVhJTGxfxQhiiwhYSNxtXMQCUsQsMJ9R4sXbWawgCWGBMIlZ134DjeLgYBFQ lfj1lAkkzCugJfHt/Bc2EFtUwEvi+68GZhCbU8BI4sSjK2AzhQTWM0p8umYCUS8o8WPyPbC9 zALyEvv2T2WFsLUk1u88zjSBUWAWkrJZSMpmISlbwMi8ilEitSC5oDgpPdcoL7Vcrzgxt7g0 L10vOT93EyM4mJ9J72A8vMv9EKMAB6MSD6/GnwuhQqyJZcWVuYcYJTiYlUR4Y7kuhQrxpiRW VqUW5ccXleakFh9ilOZgURLn1TfZFCokkJ5YkpqdmlqQWgSTZeLglGpgXHGXS0fj1Zrkv28f euVM3Tn51YlnylIV/es3CTC+blsh+X61kEZnA+f8y+9v7jQ0/tvWuZydI3VywK/JVo9FBLa9 zdsg05PNG3IzX+2A9Rp50fAusamzWj/HW/bwlC6Xtq9U8ebXvsV7dY3xqjMKT15Nyt25f8rS C6sv3JEP7T67pvLq211SvUosxRmJhlrMRcWJAL+4dZhiAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, August 17, 2015 07:19:06 PM Sergei Shtylyov wrote: > Hello. > > On 08/17/2015 06:46 PM, Bartlomiej Zolnierkiewicz wrote: > > > IDE subsystem has been deprecated since 2009 and the majority > > (if not all) of Linux distributions have switched to use > > libata for ATA support exclusively. However there are still > > some users (mostly old or/and embedded non-x86 systems) that > > have not converted from using IDE subsystem to libata PATA > > drivers. This doesn't seem to be good thing in the long-term > > for Linux as while there is less and less PATA systems left > > in use: > > > > * testing efforts are divided between two subsystems > > > > * having duplicate drivers for same hardware confuses users > > > > This patch converts generic_defconfig to use libata PATA > > drivers (sgiioc4 IDE host driver has no corresponding libata > > driver yet so it is not converted). > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > --- > > Build tested only. > > If you have affected hardware please test. Thank you. > > > > arch/ia64/configs/generic_defconfig | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig > > index 81f686d..f55be82 100644 > > --- a/arch/ia64/configs/generic_defconfig > > +++ b/arch/ia64/configs/generic_defconfig > [...] > > @@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y > > CONFIG_ATA=y > > CONFIG_ATA_PIIX=y > > CONFIG_SATA_VITESSE=y > > +CONFIG_PATA_CMD64X=y > > +CONFIG_PATA_MPIIX=y > > If you're enabling the MPIIX support (which I doubt is necessary), why not I also doubt that it is necessary but IDE's piix host driver includes support for it (so after conversion MPIIX is also enabled). > enable the "old" PIIX support? Oversight on my side, will fix. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics