From: Philipp Reisner <philipp.reisner@linbit.com>
To: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: drbd-dev@lists.linbit.com
Subject: [PATCH 2/6] drbd: fix error return code in drbd_init()
Date: Tue, 25 Jun 2013 16:50:04 +0200 [thread overview]
Message-ID: <1372171808-30515-3-git-send-email-philipp.reisner@linbit.com> (raw)
In-Reply-To: <1372171808-30515-1-git-send-email-philipp.reisner@linbit.com>
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Andreas Gruenbacher <agruen@linbit.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
---
drivers/block/drbd/drbd_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index a5dca6a..49040a3 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -2762,8 +2762,6 @@ int __init drbd_init(void)
/*
* allocate all necessary structs
*/
- err = -ENOMEM;
-
init_waitqueue_head(&drbd_pp_wait);
drbd_proc = NULL; /* play safe for drbd_cleanup */
@@ -2773,6 +2771,7 @@ int __init drbd_init(void)
if (err)
goto fail;
+ err = -ENOMEM;
drbd_proc = proc_create_data("drbd", S_IFREG | S_IRUGO , NULL, &drbd_proc_fops, NULL);
if (!drbd_proc) {
printk(KERN_ERR "drbd: unable to register proc file\n");
@@ -2803,7 +2802,6 @@ int __init drbd_init(void)
fail:
drbd_cleanup();
if (err == -ENOMEM)
- /* currently always the case */
printk(KERN_ERR "drbd: ran out of memory\n");
else
printk(KERN_ERR "drbd: initialization failure\n");
--
1.7.9.5
next prev parent reply other threads:[~2013-06-25 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 14:50 [PATCH 0/6] DRBD fixes and one functional enhancemet Philipp Reisner
2013-06-25 14:50 ` [PATCH 1/6] drbd: Do not sleep inside rcu Philipp Reisner
2013-06-25 14:50 ` Philipp Reisner [this message]
2013-06-25 14:50 ` [PATCH 3/6] drbd: Fix rcu_read_lock balance on error path Philipp Reisner
2013-06-25 14:50 ` [PATCH 4/6] drbd: Ignore the exit code of a fence-peer handler if it returns too late Philipp Reisner
2013-06-25 14:50 ` [PATCH 5/6] drbd: Constants should be UPPERCASE Philipp Reisner
2013-06-25 14:50 ` [PATCH 6/6] drbd: Allow online change of al-stripes and al-stripe-size Philipp Reisner
2013-06-28 14:05 ` [PATCH 0/6] DRBD fixes and one functional enhancemet Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2013-06-14 18:54 [PATCH 0/6] RFC: " Philipp Reisner
2013-06-14 18:54 ` [PATCH 2/6] drbd: fix error return code in drbd_init() Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372171808-30515-3-git-send-email-philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®