From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002Ab3FZJnG (ORCPT ); Wed, 26 Jun 2013 05:43:06 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:54764 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631Ab3FZJnE (ORCPT ); Wed, 26 Jun 2013 05:43:04 -0400 From: navin patidar To: gregkh@linuxfoundation.org, mfm@muteddisk.com Cc: linux-usb@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, navin patidar Subject: [PATCH v2] staging: usbip: replace pr_warning() with dev_warn(). Date: Wed, 26 Jun 2013 15:11:43 +0530 Message-Id: <1372239703-4551-1-git-send-email-navinp@cdac.in> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drivers/staging/usbip/usbip_event.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c index 82123be..3bd1b94 100644 --- a/drivers/staging/usbip/usbip_event.c +++ b/drivers/staging/usbip/usbip_event.c @@ -21,6 +21,8 @@ #include #include "usbip_common.h" +#include "stub.h" +#include "vhci.h" static int event_handler(struct usbip_device *ud) { @@ -85,7 +87,17 @@ int usbip_start_eh(struct usbip_device *ud) ud->eh = kthread_run(event_handler_loop, ud, "usbip_eh"); if (IS_ERR(ud->eh)) { - pr_warning("Unable to start control thread\n"); + struct device dev; + if (ud->side == USBIP_STUB) { + struct stub_device *sdev; + sdev = container_of(ud, struct stub_device, ud); + dev = sdev->udev->dev; + } else { + struct vhci_device *vdev; + vdev = container_of(ud, struct vhci_device, ud); + dev = vdev->udev->dev; + } + dev_warn(&dev, "Unable to start control thread\n"); return PTR_ERR(ud->eh); } -- 1.7.10.4