From: Luciano Coelho <coelho@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <grant.likely@linaro.org>, <rob.herring@calxeda.com>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
<linux-wireless@vger.kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>,
<linux-arm@vger.kernel.org>
Subject: Re: [PATCH] Documentation: dt: bindings: TI WiLink modules
Date: Thu, 27 Jun 2013 16:30:10 +0300 [thread overview]
Message-ID: <1372339810.8383.20.camel@cumari.coelho.fi> (raw)
In-Reply-To: <51CC3CEE.3050004@ti.com>
On Thu, 2013-06-27 at 08:23 -0500, Nishanth Menon wrote:
> On 06/27/2013 08:19 AM, Luciano Coelho wrote:
> > On Thu, 2013-06-27 at 08:15 -0500, Nishanth Menon wrote:
> >> On Thu, Jun 27, 2013 at 7:58 AM, Luciano Coelho <coelho@ti.com> wrote:
> >>> For the actual DTS files, I could add a wilink.dtsi with enumerations
> >>> for these values so they could be used in the node definitions. But I'm
> >>> not sure it's going to be that valuable in the end.
> >> The way GPIO HIGH was defined might help to provide guidance I think :)
> >
> > Where? As far as I can see, the GPIO flags are defined in a bitmap.
>
> include/dt-bindings/gpio/gpio.h
Thanks! I don't see these macros used anywhere, though.
> And corresponding kernel header:
> include/linux/of_gpio.h
This seems to be a completely different thing. This is the header that
contains the helper functions to get GPIO-related device tree nodes,
isn't it?
> just a hint. not saying frequencies were defined in header. for systems
> that define frequencies - example cpufreq OPPs, clock node usage, we do
> not use indexing to frequency, instead, that is the responsibility of
> driver to convert frequency back to required index.
> git grep frequency Documentation/devicetree/bindings gives you how the
> precedence looks like.
>
> Personally, if given a choice, I'd go with actual frequencies rather
> than indexes.
If I do that, I need to add also a separate flag to define whether the
XTAL clock is used or not. For instance, we have 26MHz and 26MHz
crystal; and 38.4MHz and 38.4MHz crystal...
--
Luca.
next prev parent reply other threads:[~2013-06-27 13:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 8:35 Luciano Coelho
2013-06-25 11:12 ` Felipe Balbi
2013-06-25 11:56 ` Luciano Coelho
2013-06-25 13:07 ` Felipe Balbi
2013-06-25 19:35 ` Luciano Coelho
2013-06-25 19:37 ` Luciano Coelho
2013-06-26 6:24 ` Tony Lindgren
2013-06-26 8:13 ` Luciano Coelho
2013-06-26 8:22 ` Tony Lindgren
[not found] ` <51CBC1C8.1040301@gmail.com>
2013-06-27 8:47 ` Luciano Coelho
2013-06-27 12:51 ` Nishanth Menon
2013-06-27 12:58 ` Luciano Coelho
2013-06-27 13:15 ` Nishanth Menon
2013-06-27 13:19 ` Luciano Coelho
2013-06-27 13:23 ` Nishanth Menon
2013-06-27 13:30 ` Luciano Coelho [this message]
2013-06-27 13:39 ` Nishanth Menon
2013-06-27 18:51 ` Luciano Coelho
2013-06-27 19:12 ` Nishanth Menon
2013-06-27 19:46 ` Luciano Coelho
2013-06-27 19:56 ` Nishanth Menon
2013-06-28 9:38 ` Mark Rutland
2013-06-28 9:53 ` Luciano Coelho
2013-06-28 10:21 ` Mark Rutland
2013-06-28 10:31 ` Luciano Coelho
2013-06-28 11:22 ` Luciano Coelho
2013-06-28 11:41 ` Felipe Balbi
2013-06-28 12:13 ` Luciano Coelho
2013-06-28 12:18 ` Felipe Balbi
2013-06-28 13:21 ` Luciano Coelho
2013-07-01 12:39 ` Luciano Coelho
2013-07-17 23:58 ` Laurent Pinchart
2013-07-20 7:48 ` Luciano Coelho
2013-06-28 10:33 ` Mark Rutland
2013-06-28 10:39 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372339810.8383.20.camel@cumari.coelho.fi \
--to=coelho@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nm@ti.com \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®