From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754219Ab3F0Ssa (ORCPT ); Thu, 27 Jun 2013 14:48:30 -0400 Received: from mail-ve0-f202.google.com ([209.85.128.202]:61516 "EHLO mail-ve0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156Ab3F0Ss2 (ORCPT ); Thu, 27 Jun 2013 14:48:28 -0400 From: Doug Anderson To: linux-kernel@vger.kernel.org Cc: Mike Frysinger , Olof Johansson , Doug Anderson , Michal Marek , linux-kbuild@vger.kernel.org Subject: [PATCH] kbuild: Avoid race generating / using MODLIB Date: Thu, 27 Jun 2013 11:48:04 -0700 Message-Id: <1372358884-12269-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.8.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The $(MODLIB) variable is recursively expanded and is: $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE) The $(KERNELRELEASE) variable is also recursively expanded: $(shell cat include/config/kernel.release 2> /dev/null) The file being read is a generated by the Makefile itself. When the file is generated it is removed and then recreated. This leaves a period of time when the file doesn't exist. If we happen to use $(MODLIB) during this time then we'll end up with a bad value. This is fairly easy for me to reproduce by: * Add a "sleep 2" between the 'rm -f $@' and the 'echo' in the rule to build 'include/config/kernel.release' * make -j32 ARCH=arm CROSS_COMPILE=armv7a-cros-linux-gnueabi- \ zImage dtbs modules * make -j32 ARCH=arm CROSS_COMPILE=armv7a-cros-linux-gnueabi- \ INSTALL_PATH=foo INSTALL_MOD_PATH=foomod \ install firmware_install modules_install Without trying to rethink the whole KERNELRELEASE variable, the simple fix is to just add a dependency. Signed-off-by: Doug Anderson --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 0142c93..9cf2b24 100644 --- a/Makefile +++ b/Makefile @@ -964,7 +964,7 @@ PHONY += modules_install modules_install: _modinst_ _modinst_post PHONY += _modinst_ -_modinst_: +_modinst_: include/config/kernel.release @rm -rf $(MODLIB)/kernel @rm -f $(MODLIB)/source @mkdir -p $(MODLIB)/kernel @@ -1232,7 +1232,7 @@ modules_install: _emodinst_ _emodinst_post install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra) PHONY += _emodinst_ -_emodinst_: +_emodinst_: include/config/kernel.release $(Q)mkdir -p $(MODLIB)/$(install-dir) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst -- 1.8.3