From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH V3 15/15] perf tools: change "machine" functions to set thread pid
Date: Fri, 28 Jun 2013 11:43:26 +0300 [thread overview]
Message-ID: <1372409006-8431-16-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1372409006-8431-1-git-send-email-adrian.hunter@intel.com>
Typically tracking events such as mmap events, comm events,
fork events and exit events, are processed by "machine"
functions. Change these functions to put pid in the new
pid_ member of struct thread.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/machine.c | 21 +++++++++++++++++----
tools/perf/util/machine.h | 2 ++
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 722281a..d11ca3b 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -287,6 +287,12 @@ struct thread *machine__findnew_thread(struct machine *machine, pid_t tid)
return __machine__findnew_thread(machine, 0, tid, true);
}
+struct thread *machine__findnew_thread_ex(struct machine *machine, pid_t pid,
+ pid_t tid)
+{
+ return __machine__findnew_thread(machine, pid, tid, true);
+}
+
struct thread *machine__find_thread(struct machine *machine, pid_t tid)
{
return __machine__findnew_thread(machine, 0, tid, false);
@@ -294,7 +300,9 @@ struct thread *machine__find_thread(struct machine *machine, pid_t tid)
int machine__process_comm_event(struct machine *machine, union perf_event *event)
{
- struct thread *thread = machine__findnew_thread(machine, event->comm.tid);
+ struct thread *thread = machine__findnew_thread_ex(machine,
+ event->comm.pid,
+ event->comm.tid);
if (dump_trace)
perf_event__fprintf_comm(event, stdout);
@@ -975,7 +983,8 @@ int machine__process_mmap_event(struct machine *machine, union perf_event *event
return 0;
}
- thread = machine__findnew_thread(machine, event->mmap.pid);
+ thread = machine__findnew_thread_ex(machine, event->mmap.pid,
+ event->mmap.pid);
if (thread == NULL)
goto out_problem;
@@ -1002,8 +1011,12 @@ out_problem:
int machine__process_fork_event(struct machine *machine, union perf_event *event)
{
- struct thread *thread = machine__findnew_thread(machine, event->fork.tid);
- struct thread *parent = machine__findnew_thread(machine, event->fork.ptid);
+ struct thread *thread = machine__findnew_thread_ex(machine,
+ event->fork.pid,
+ event->fork.tid);
+ struct thread *parent = machine__findnew_thread_ex(machine,
+ event->fork.ppid,
+ event->fork.ptid);
if (dump_trace)
perf_event__fprintf_task(event, stdout);
diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h
index 221a0a9..11a53d5 100644
--- a/tools/perf/util/machine.h
+++ b/tools/perf/util/machine.h
@@ -100,6 +100,8 @@ static inline bool machine__is_host(struct machine *machine)
}
struct thread *machine__findnew_thread(struct machine *machine, pid_t tid);
+struct thread *machine__findnew_thread_ex(struct machine *machine, pid_t pid,
+ pid_t tid);
size_t machine__fprintf(struct machine *machine, FILE *fp);
--
1.7.11.7
prev parent reply other threads:[~2013-06-28 8:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 8:43 [PATCH V3 00/15] perf tools: some fixes and tweaks Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 01/15] perf tools: remove unused parameter Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 02/15] perf tools: fix missing tool parameter Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 03/15] perf tools: fix missing 'finished_round' Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 04/15] perf tools: fix parse_events_terms() segfault on error path Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 05/15] perf tools: fix new_term() missing free " Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 06/15] perf tools: fix parse_events_terms() freeing local variable " Adrian Hunter
2013-06-28 9:56 ` Jiri Olsa
2013-06-28 17:19 ` David Ahern
2013-07-01 8:01 ` Adrian Hunter
2013-07-01 18:46 ` David Ahern
2013-07-02 6:26 ` Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 07/15] perf tools: add const specifier to perf_pmu__find name parameter Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 08/15] perf tools: tidy duplicated munmap code Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 09/15] perf tools: validate perf event header size Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 10/15] perf tools: add debug prints Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 11/15] perf tools: fix symbol_conf.nr_events Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 12/15] perf tools: allow non-matching sample types Adrian Hunter
2013-06-28 8:43 ` [PATCH V3 13/15] perf tools: struct thread has a tid not a pid Adrian Hunter
2013-06-28 17:24 ` David Ahern
2013-06-28 8:43 ` [PATCH V3 14/15] perf tools: add pid to struct thread Adrian Hunter
2013-06-28 17:27 ` David Ahern
2013-06-28 8:43 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372409006-8431-16-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome