From: Johan Hovold <jhovold@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Anders Hammarquist <iko@iko.pp.se>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Johan Hovold <jhovold@gmail.com>, stable <stable@vger.kernel.org>
Subject: [PATCH] USB: ti_usb_3410_5052: fix dynamic-id matching
Date: Fri, 28 Jun 2013 12:24:26 +0200 [thread overview]
Message-ID: <1372415066-1031-1-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <20130628102333.GA13241@localhost>
The driver failed to take the dynamic ids into account when determining
the device type and therefore all devices were detected as 2-port
devices when using the dynamic-id interface.
Match on the usb-serial-driver field instead of doing redundant id-table
searches.
Reported-by: Anders Hammarquist <iko@iko.pp.se>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/usb/serial/ti_usb_3410_5052.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index 5585b20..5c07d55 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -309,7 +309,7 @@ static int ti_startup(struct usb_serial *serial)
usb_set_serial_data(serial, tdev);
/* determine device type */
- if (usb_match_id(serial->interface, ti_id_table_3410))
+ if (serial->type == &ti_1port_device)
tdev->td_is_3410 = 1;
dev_dbg(&dev->dev, "%s - device type is %s\n", __func__,
tdev->td_is_3410 ? "3410" : "5052");
--
1.8.2.1
next prev parent reply other threads:[~2013-06-28 10:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 0:05 [PATCH 0/2] *** SUBJECT HERE *** Anders Hammarquist
2013-06-19 22:53 ` Greg KH
2013-06-21 23:08 ` Anders Hammarquist
2013-06-21 23:56 ` Greg KH
2013-06-22 18:54 ` Anders Hammarquist
2013-06-25 23:39 ` Greg KH
2013-06-26 8:29 ` Anders Hammarquist
2013-06-26 10:39 ` Johan Hovold
2013-06-27 21:50 ` Anders Hammarquist
2013-06-28 10:23 ` Johan Hovold
2013-06-28 10:24 ` Johan Hovold [this message]
2013-07-01 23:22 ` Anders Hammarquist
2013-07-02 9:46 ` Johan Hovold
2013-06-22 18:55 ` [PATCH 1/2] * Remove unused and overly generic ABBOTT_PRODUCT_ID * Fix sizes of statically sized usb_debvice_id tables Anders Hammarquist
2013-06-22 18:55 ` [PATCH 2/2] Remove static sizing of usb_device_id arrays Anders Hammarquist
2013-07-24 22:52 ` Greg KH
2013-07-25 14:15 ` Anders Hammarquist
2013-07-25 14:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372415066-1031-1-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iko@iko.pp.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome