mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiaxing Wang <hello.wjx@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: Jiaxing Wang <hello.wjx@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] seq_file:update file->f_pos when lseek() to m->read_pos
Date: Sat, 29 Jun 2013 17:11:35 +0800	[thread overview]
Message-ID: <1372497096-15914-1-git-send-email-hello.wjx@gmail.com> (raw)

After pread(), file->f_pos and m->read_pos get different,
and lseek() to m->read_pos did not update file->f_pos, then
a subsequent read may read from a wrong position, the following
program shows the problem:

    char str1[32] = { 0 };
    char str2[32] = { 0 };
    int poffset = 10;
    int count = 20;

    /*open any seq file*/
    int fd = open("/proc/modules", O_RDONLY);

    pread(fd, str1, count, poffset);
    printf("pread:%s\n", str1);

    /*seek to where m->read_pos is*/
    lseek(fd, poffset+count, SEEK_SET);

    /*supposed to read from poffset+count, but this read from position 0*/
    read(fd, str2, count);
    printf("read:%s\n", str2);

Signed-off-by: Jiaxing Wang <hello.wjx@gmail.com>
---
 fs/seq_file.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/seq_file.c b/fs/seq_file.c
index 774c1eb..4b22b26 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -328,7 +328,8 @@ loff_t seq_lseek(struct file *file, loff_t offset, int whence)
 				m->read_pos = offset;
 				retval = file->f_pos = offset;
 			}
-		}
+		} else
+			file->f_pos = offset;
 	}
 	file->f_version = m->version;
 	mutex_unlock(&m->lock);
-- 
1.8.1.2


             reply	other threads:[~2013-06-29  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-29  9:11 Jiaxing Wang [this message]
2013-07-01 12:41 ` fangdong
2013-07-02  0:43   ` Jiaxing Wang
2013-07-04  2:00     ` Gu Zheng
2013-07-01 12:52 ` Dong Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372497096-15914-1-git-send-email-hello.wjx@gmail.com \
    --to=hello.wjx@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome