From: Luciano Coelho <coelho@ti.com>
To: <balbi@ti.com>
Cc: <linux-wireless@vger.kernel.org>, <tony@atomide.com>,
<nsekhar@ti.com>, <mturquette@linaro.org>, <mark.rutland@arm.com>,
<grant.likely@linaro.org>, <rob.herring@calxeda.com>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 5/9] wlcore: always use one-shot IRQ
Date: Tue, 2 Jul 2013 23:16:58 +0300 [thread overview]
Message-ID: <1372796218.21065.87.camel@cumari.coelho.fi> (raw)
In-Reply-To: <20130702153229.GG7013@arwen.pp.htv.fi>
On Tue, 2013-07-02 at 18:32 +0300, Felipe Balbi wrote:
> On Tue, Jul 02, 2013 at 05:55:44PM +0300, Luciano Coelho wrote:
> > Since we are now using threaded IRQs without the primary handler, we
> > need to set IRQF_ONESHOT, otherwise our request will fail.
> >
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
>
> good to see this happening, I remember we talked about this a while back
> :-)
Yeah, we talked about it and I did the patch immediately. This is
needed because this is obviously not set automatically in the interrupts
created via device tree.
> Acked-by: Felipe Balbi <balbi@ti.com>
>
> Still, if you call irq_set_irq_type() on board-file (since DT will do
> something similar for you anyway) then you can completely drop
> irq_flags.
Yep.
--
Luca.
next prev parent reply other threads:[~2013-07-02 20:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 14:55 [PATCH v2 0/9] wilink: add device tree support Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 1/9] wl1251: split wl251 platform data to a separate structure Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 2/9] wlcore: use irq_flags in pdata instead of hiding it behind a quirk Luciano Coelho
2013-07-02 15:26 ` Felipe Balbi
2013-07-02 20:12 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 3/9] wlcore: remove pwr_in_suspend from platform data Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 4/9] wl12xx: use frequency instead of enumerations for pdata clocks Luciano Coelho
2013-07-02 15:02 ` Nishanth Menon
2013-07-02 20:27 ` Luciano Coelho
2013-07-03 11:33 ` Tony Lindgren
2013-07-03 12:14 ` Luciano Coelho
2013-07-02 15:31 ` Felipe Balbi
2013-07-02 20:14 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 5/9] wlcore: always use one-shot IRQ Luciano Coelho
2013-07-02 15:32 ` Felipe Balbi
2013-07-02 20:16 ` Luciano Coelho [this message]
2013-07-02 14:55 ` [PATCH v2 6/9] wlcore: add initial device tree support to the sdio module Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 7/9] wlcore: sdio: add wilink clock providers Luciano Coelho
2013-07-02 15:34 ` Felipe Balbi
2013-07-02 21:30 ` Felipe Balbi
2013-07-02 14:55 ` [PATCH v2 8/9] wlcore: sdio: get clocks from device tree Luciano Coelho
2013-07-02 15:35 ` Felipe Balbi
2013-07-02 20:19 ` Luciano Coelho
2013-07-02 21:32 ` Felipe Balbi
2013-07-02 21:38 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 9/9] wlcore/wl12xx: check if we got correct clock data from DT Luciano Coelho
2013-07-03 10:13 ` [PATCH v2 0/9] wilink: add device tree support Grazvydas Ignotas
2013-07-03 13:45 ` Luciano Coelho
2013-09-21 12:27 ` Pavel Machek
2013-09-21 14:16 ` Sebastian Reichel
2013-09-22 13:36 ` Pavel Machek
2013-09-22 14:24 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372796218.21065.87.camel@cumari.coelho.fi \
--to=coelho@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®