From: "Jon Arne Jørgensen" <jonarne@jonarne.no>
To: linux-media@vger.kernel.org
Cc: jonarne@jonarne.no, linux-kernel@vger.kernel.org,
mchehab@redhat.com, hans.verkuil@cisco.com,
prabhakar.csengg@gmail.com, laurent.pinchart@ideasonboard.com,
andriy.shevchenko@linux.intel.com
Subject: [RFC v3 2/3] saa7115: Do not load saa7115_init_misc for gm7113c
Date: Thu, 4 Jul 2013 01:27:19 +0200 [thread overview]
Message-ID: <1372894040-23922-3-git-send-email-jonarne@jonarne.no> (raw)
In-Reply-To: <1372894040-23922-1-git-send-email-jonarne@jonarne.no>
Most of the registers changed in saa7115_init_misc table are out of range
for the gm7113c chip.
The only register that's within range doesn't need to be changed here.
Signed-off-by: Jon Arne Jørgensen <jonarne@jonarne.no>
---
drivers/media/i2c/saa7115.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c
index 41408dd..17a464d 100644
--- a/drivers/media/i2c/saa7115.c
+++ b/drivers/media/i2c/saa7115.c
@@ -1769,7 +1769,7 @@ static int saa711x_probe(struct i2c_client *client,
state->crystal_freq = SAA7115_FREQ_32_11_MHZ;
saa711x_writeregs(sd, saa7115_init_auto_input);
}
- if (state->ident > SAA7111A)
+ if (state->ident > SAA7111A && state->ident != GM7113C)
saa711x_writeregs(sd, saa7115_init_misc);
saa711x_set_v4lstd(sd, V4L2_STD_NTSC);
v4l2_ctrl_handler_setup(hdl);
--
1.8.3.1
next prev parent reply other threads:[~2013-07-03 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 23:27 [RFC v3 0/3] saa7115: Implement i2c_board_info.platform_data Jon Arne Jørgensen
2013-07-03 23:27 ` [RFC v3 1/3] saa7115: Fix saa711x_set_v4lstd for gm7113c Jon Arne Jørgensen
2013-07-03 23:27 ` Jon Arne Jørgensen [this message]
2013-07-03 23:27 ` [RFC v3 3/3] saa7115: Implement i2c_board_info.platform_data Jon Arne Jørgensen
2013-07-26 13:54 ` Hans Verkuil
[not found] ` <jonarne-tmp12w3123344232sd>
2013-07-30 11:33 ` Jon Arne Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372894040-23922-3-git-send-email-jonarne@jonarne.no \
--to=jonarne@jonarne.no \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®