mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>
Cc: <linux-kernel@vger.kernel.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Subject: [PATCH 3/4] video: make goldfish video depend on GOLDFISH || COMPILE_TEST
Date: Thu, 4 Jul 2013 01:39:12 -0400	[thread overview]
Message-ID: <1372916353-24050-4-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1372916353-24050-1-git-send-email-paul.gortmaker@windriver.com>

Nearly all the other goldfish peripherals (mtd, keyboard, etc)
have a dependency on the main platform's GOLDFISH Kconfig item,
but this one got skipped.  It was suggested to add it earlier[1],
but that never got responded to or picked up -- presumably because
some developers desired the extra compile coverage at the cost of
exposing unusable options to end users.

With CONFIG_COMPILE_TEST, we can have the best of both worlds.
Add the GOLDFISH dependency, in conjunction with COMPILE_TEST.

[1] https://lkml.org/lkml/2013/2/27/169

Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 2e937bd..630b637 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2199,7 +2199,7 @@ config FB_XILINX
 
 config FB_GOLDFISH
 	tristate "Goldfish Framebuffer"
-	depends on FB && HAS_DMA
+	depends on FB && HAS_DMA && (GOLDFISH || COMPILE_TEST)
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
1.8.1.2


  parent reply	other threads:[~2013-07-04  5:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04  5:39 [RFC PATCH 0/4] CONFIG_COMPILE_TEST: additional examples and checkpatch rule Paul Gortmaker
2013-07-04  5:39 ` [PATCH 1/4] usb: limit OMAP related USB options to OMAP2PLUS platforms Paul Gortmaker
2013-07-08  7:56   ` Felipe Balbi
2013-07-04  5:39 ` [PATCH 2/4] power: make goldfish_battery depend on GOLDFISH || COMPILE_TEST Paul Gortmaker
2013-08-09 20:32   ` Anton Vorontsov
2013-07-04  5:39 ` Paul Gortmaker [this message]
2013-07-04  5:39 ` [PATCH 4/4] checkpatch: only allow COMPILE_TEST in Kconfig dependency lines Paul Gortmaker
2013-07-04  8:10   ` Geert Uytterhoeven
2013-07-04  8:55   ` Arnd Bergmann
2013-07-04 15:41   ` Joe Perches
2013-07-04 17:09     ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372916353-24050-4-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®