mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@infradead.org, arm@kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>
Subject: [PATCH 1/8] clocksource: armada-xp: always register local_timer_ops
Date: Fri,  5 Jul 2013 18:23:30 +0200	[thread overview]
Message-ID: <1373041417-217728-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1373041417-217728-1-git-send-email-arnd@arndb.de>

The call to local_timer_register is hidden behind an #ifdef, which
turns the armada_370_xp_local_timer_ops into a potentially unused
variable, causing this warning:

time-armada-370-xp.c:208:31: warning: 'armada_370_xp_local_timer_ops' defined but not used [-Wunused-variable]
 static struct local_timer_ops armada_370_xp_local_timer_ops __cpuinitdata = {
                               ^

Since local_timer_register() itself doesn't do anything, just removing
the #ifdef makes the code look nicer and gets rid of the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 drivers/clocksource/time-armada-370-xp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
index 47a6730..4cd8520 100644
--- a/drivers/clocksource/time-armada-370-xp.c
+++ b/drivers/clocksource/time-armada-370-xp.c
@@ -294,8 +294,6 @@ void __init armada_370_xp_timer_init(void)
 				percpu_armada_370_xp_evt);
 	if (!res) {
 		enable_percpu_irq(armada_370_xp_clkevt.irq, 0);
-#ifdef CONFIG_LOCAL_TIMERS
 		local_timer_register(&armada_370_xp_local_timer_ops);
-#endif
 	}
 }
-- 
1.8.3.1


  reply	other threads:[~2013-07-05 16:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 16:23 [PATCH 0/8] ARM: SoC specific bug fixes Arnd Bergmann
2013-07-05 16:23 ` Arnd Bergmann [this message]
2013-07-05 16:33   ` [PATCH 1/8] clocksource: armada-xp: always register local_timer_ops Gregory CLEMENT
2013-07-05 16:57     ` Stephen Boyd
2013-07-05 16:23 ` [PATCH 2/8] ARM: omap5: omap5 has SCU and TWD Arnd Bergmann
2013-07-08 12:03   ` Tony Lindgren
2013-07-05 16:23 ` [PATCH 3/8] ARM: zynq: use DT_MACHINE_START Arnd Bergmann
2013-07-08  6:18   ` Michal Simek
2013-07-05 16:23 ` [PATCH 4/8] ARM: OMAP: build mach-omap code only if needed Arnd Bergmann
2013-07-08 11:31   ` Olof Johansson
2013-07-08 11:34     ` Olof Johansson
2013-07-08 12:00   ` Tony Lindgren
2013-07-05 16:23 ` [PATCH 5/8] ARM: sti: move DEBUG_STI_UART into alphabetical order Arnd Bergmann
2013-07-05 16:23 ` [PATCH 6/8] ARM: OMAP: omap_common_late_init may be unused Arnd Bergmann
2013-07-08 12:01   ` Tony Lindgren
2013-07-05 16:23 ` [PATCH 7/8] ARM: ixp4xx: avoid circular header dependency Arnd Bergmann
2013-07-06 18:11   ` Krzysztof Halasa
2013-07-05 16:23 ` [PATCH 8/8] ARM: exynos: select PM_GENERIC_DOMAINS only when used Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373041417-217728-2-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®