From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 3/3] irq: add lock annotation to squelch a sparse warning
Date: Sat, 6 Jul 2013 17:41:26 +0530 [thread overview]
Message-ID: <1373112686-28501-4-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1373112686-28501-1-git-send-email-artagnon@gmail.com>
__irq_put_desc_unlock() releases &desc->lock, but being a static
analyzer, sparse emits a warning:
context imbalance in '__irq_put_desc_unlock' - unexpected unlock
Help it by annotating the function with a __release. Do not annotate
its counterpart which acquires the lock, __irq_get_desc_lock(), because
it does so conditionally.
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
kernel/irq/irqdesc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 192a302..d6bc26a 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -449,6 +449,7 @@ __irq_get_desc_lock(unsigned int irq, unsigned long *flags, bool bus,
}
void __irq_put_desc_unlock(struct irq_desc *desc, unsigned long flags, bool bus)
+ __releases(&desc->lock)
{
raw_spin_unlock_irqrestore(&desc->lock, flags);
if (bus)
--
1.8.3.2.733.gf8abaeb
next prev parent reply other threads:[~2013-07-06 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 12:11 [PATCH 0/3] Trivial sparse acquire/release annotations Ramkumar Ramachandra
2013-07-06 12:11 ` [PATCH 1/3] nfs: add lock annotations to squelch sparse warnings Ramkumar Ramachandra
2013-07-06 12:11 ` [PATCH 2/3] apic: " Ramkumar Ramachandra
2013-07-06 12:11 ` Ramkumar Ramachandra [this message]
2013-09-23 14:41 ` [PATCH 0/3] Trivial sparse acquire/release annotations Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373112686-28501-4-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®