From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Kent Overstreet <kmo@daterainc.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
tj@kernel.org, sfr@canb.auug.org.au, andi@firstfloor.org,
oleg@redhat.com, mingo@redhat.com, axboe@kernel.dk,
"Michael S. Tsirkin" <mst@redhat.com>,
target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH v3] lib/idr.c rewrite, percpu ida/tag allocator
Date: Sat, 06 Jul 2013 15:59:06 -0700 [thread overview]
Message-ID: <1373151546.7397.55.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <1373087301-23730-1-git-send-email-kmo@daterainc.com>
On Fri, 2013-07-05 at 22:08 -0700, Kent Overstreet wrote:
> Previous posting: http://thread.gmane.org/gmane.linux.kernel/1511216
>
> The only real change since the last version is that I've reworked the
> new ida implementation to not use one giant allocation - it's still
> logically one big arary, but it's implemented as an array of arrays.
>
> With that, it scales up to INT_MAX allocated ids just fine. Benchmarks
> are included in that patch.
>
> Patch series is available in my git repo:
> git://evilpiepirate.org/~kent/linux-bcache.git idr
>
> Andrew, want to pick this up for 3.12?
Just FYI that the target-pending/target-per-cpu-ida branch utilizing
per-cpu ida logic for vhost-scsi has been rebased to include this latest
series. Thanks Kent!
Andrew, what are your plans for this..?
Would you consider allowing this series be merged through target-pending
in order to allow us to start taking advantage of per-cpu ida tag
pre-allocation optimizations for v3.12 target code..?
Another option would be to merge the per-cpu ida specific piece now for
v3.11 for which the risk is low given it doesn't touch any existing
code, and then include Kent's full idr rewrite separately as v3.12 item.
WDYT..?
--nab
next prev parent reply other threads:[~2013-07-06 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 5:08 Kent Overstreet
2013-07-06 5:08 ` [PATCH 03/10] idr: Rewrite ida Kent Overstreet
2013-07-06 5:08 ` [PATCH 04/10] idr: Percpu ida Kent Overstreet
2013-07-06 5:08 ` [PATCH 05/10] idr: Kill old deprecated idr interfaces Kent Overstreet
2013-07-06 5:08 ` [PATCH 06/10] idr: Rename idr_get_next() -> idr_find_next() Kent Overstreet
2013-07-06 5:08 ` [PATCH 08/10] idr: Reimplement idr on top of ida/radix trees Kent Overstreet
2013-07-06 22:59 ` Nicholas A. Bellinger [this message]
2013-07-07 11:48 ` [PATCH v3] lib/idr.c rewrite, percpu ida/tag allocator Michael S. Tsirkin
2013-07-08 2:09 ` Nicholas A. Bellinger
2013-07-08 5:21 ` Michael S. Tsirkin
2013-07-08 20:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373151546.7397.55.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=oleg@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=target-devel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®