From: Joe Perches <joe@perches.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
Jim Garlick <garlick@llnl.gov>,
Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible
Date: Sun, 07 Jul 2013 21:54:27 -0700 [thread overview]
Message-ID: <1373259267.1893.7.camel@joe-AO722> (raw)
In-Reply-To: <20130708044542.GE20091@localhost>
On Mon, 2013-07-08 at 12:45 +0800, Fengguang Wu wrote:
> On Sun, Jul 07, 2013 at 08:54:04PM -0700, Joe Perches wrote:
> > On Mon, 2013-07-08 at 11:30 +0800, Fengguang Wu wrote:
> > > In long run I'd like to disable
> > > the check types that tend to have false positives. As for now, these
> > > checks are disabled in my checkpatch robot:
> >
> > Are you using a .checkpatch.conf file?
>
> Nope.
>
> > > PATCH_PREFIX
> > > LONG_LINE
> > > CAMELCASE
> >
> > That's a --strict test
>
> Yes. The CAMELCASE checks are false positives for the USB subsystem.
> Where they followed the USB spec and use names like bInterfaceClass
> all over the places.
The latest version of checkpatch should avoid this.
> > > MISSING_SIGN_OFF
> >
> > Why would you even consider this one?
>
> It produces
>
> ERROR: Missing Signed-off-by: line(s)
>
> on
> commit: 8bb495e3f02401ee6f76d1b1d77f3ac9f079e376 Linux 3.10
Well, clearly Linus should sign off on his own commits...
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git master
> commit: 97966e7ec944580bc3f46712f34ecb3c854fdd4b [37/81] Revert "ALSA: hda - Fix wrong power setup for HP paths of VIA codecs"
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git master
> head: 120b1922175789a8a9bdafb7ea755fc63de2f392
> commit: 10296279acc5d3caeca7b2cfde329c8280fe67e5 [32/81] Merge branch 'for-linus'
>
> and many other commits
Not in -next as of today.
> > > TRAILING_STATEMENTS
> > False positives? Got an example?
> tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next
> head: d2989b534ef6834ebf2425aecc040b894b567c91
> commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy engine context stored in ramfc, not externally
>
> ERROR: trailing statements should be on next line
> #28: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:146:
> + case NVDEV_ENGINE_GR : addr = 0x0210; break;
Not false positives.
next prev parent reply other threads:[~2013-07-08 4:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51d9c6c4.k6qhnvy45dNR8Ghq%fengguang.wu@intel.com>
[not found] ` <20130708004233.GA8958@localhost>
[not found] ` <CAFkjPTk5EZ_d5BdTTHjgrwdtU1XfZ3go_7ZDCv4Q_oqnn95AHg@mail.gmail.com>
2013-07-08 3:30 ` Fengguang Wu
2013-07-08 3:54 ` Joe Perches
2013-07-08 4:45 ` Fengguang Wu
2013-07-08 4:47 ` Fengguang Wu
2013-07-08 4:57 ` Fengguang Wu
2013-07-08 4:54 ` Joe Perches [this message]
2013-07-08 7:28 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373259267.1893.7.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=ericvh@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=garlick@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®