mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xen.org>, <linux-kernel@vger.kernel.org>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH RFC 3/4] xen-blkfront: prevent hoarding all grants
Date: Mon, 8 Jul 2013 15:03:26 +0200	[thread overview]
Message-ID: <1373288607-1876-4-git-send-email-roger.pau@citrix.com> (raw)
In-Reply-To: <1373288607-1876-1-git-send-email-roger.pau@citrix.com>

Prevent blkfront from hoarding all grants by adding a minimum number
of grants that must be free at all times. We still need a way to free
unused grants in blkfront, but this patch will mitigate the problem
in the meantime.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/block/xen-blkfront.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 187a437..3d445c0 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -101,6 +101,12 @@ MODULE_PARM_DESC(max, "Maximum amount of segments in indirect requests (default
 #define BLK_RING_SIZE __CONST_RING_SIZE(blkif, PAGE_SIZE)
 
 /*
+ * Make sure there are at least MIN_FREE_GRANTS at all times, preventing
+ * blkfront from hoarding all grants
+ */
+#define MIN_FREE_GRANTS		512
+
+/*
  * We have one of these per vbd, whether ide, scsi or 'other'.  They
  * hang in private_data off the gendisk structure. We may end up
  * putting all kinds of interesting stuff here :-)
@@ -412,13 +418,13 @@ static int blkif_queue_request(struct request *req)
 	if (info->persistent_gnts_c < max_grefs) {
 		new_persistent_gnts = 1;
 		if (gnttab_alloc_grant_references(
-		    max_grefs - info->persistent_gnts_c,
+		    max_grefs - info->persistent_gnts_c + MIN_FREE_GRANTS,
 		    &gref_head) < 0) {
 			gnttab_request_free_callback(
 				&info->callback,
 				blkif_restart_queue_callback,
 				info,
-				max_grefs);
+				max_grefs + MIN_FREE_GRANTS);
 			return 1;
 		}
 	} else
-- 
1.7.7.5 (Apple Git-26)


  parent reply	other threads:[~2013-07-08 13:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 13:03 [PATCH RFC 0/4] xen-block: prevent blkfront for hoarding grants Roger Pau Monne
2013-07-08 13:03 ` [PATCH RFC 1/4] xen-gnt: prevent adding duplicate gnt callbacks Roger Pau Monne
2013-07-11 13:17   ` [Xen-devel] " David Vrabel
2013-07-11 16:23     ` Roger Pau Monné
2013-07-08 13:03 ` [PATCH RFC 2/4] xen-blkfront: improve aproximation of required grants per request Roger Pau Monne
2013-07-11 13:20   ` [Xen-devel] " David Vrabel
2013-07-11 14:47     ` Roger Pau Monné
2013-07-08 13:03 ` Roger Pau Monne [this message]
2013-07-11 13:32   ` [Xen-devel] [PATCH RFC 3/4] xen-blkfront: prevent hoarding all grants David Vrabel
2013-07-11 14:57     ` Roger Pau Monné
2013-07-08 13:03 ` [PATCH RFC 4/4] xen-block: introduce a new request type to unmap grants Roger Pau Monne
2013-07-08 19:41   ` Konrad Rzeszutek Wilk
2013-07-09 13:22     ` [Xen-devel] " Wei Liu
2013-07-09 16:37     ` Roger Pau Monné
2013-07-09 18:32       ` Konrad Rzeszutek Wilk
2013-07-09 18:38         ` [Xen-devel] " Wei Liu
2013-07-10  9:19     ` Roger Pau Monné
2013-07-10 13:54       ` [Xen-devel] " Egger, Christoph
2013-07-10 14:46         ` Roger Pau Monné
2013-07-10 14:52       ` Konrad Rzeszutek Wilk
2013-07-11 13:48       ` [Xen-devel] " David Vrabel
2013-07-11 15:12         ` Roger Pau Monné
2013-07-11 15:26           ` David Vrabel
2013-07-11 15:48             ` Roger Pau Monné
2013-07-12 10:12               ` David Vrabel
2013-07-11 13:35 ` [Xen-devel] [PATCH RFC 0/4] xen-block: prevent blkfront for hoarding grants David Vrabel
2013-07-31  9:50 ` Roger Pau Monné
2013-07-31 11:27   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373288607-1876-4-git-send-email-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®