From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: balbi@ti.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>
Subject: [PATCH v2 4/7] usb: phy: msm: Remove unnecessarily check for valid regulators.
Date: Tue, 9 Jul 2013 18:47:10 +0300 [thread overview]
Message-ID: <1373384833-18077-5-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1373384833-18077-1-git-send-email-iivanov@mm-sol.com>
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Whether regulators are available or not is checked at driver
probe. If they are not available driver will refuse to load,
so no need to check them again.
Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
---
drivers/usb/phy/phy-msm-usb.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 8289270..0e7d7ab 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -159,16 +159,6 @@ static int msm_hsusb_ldo_set_mode(struct msm_otg *motg, int on)
{
int ret = 0;
- if (!motg->v1p8 || IS_ERR(motg->v1p8)) {
- pr_err("%s: HSUSB_1p8 is not initialized\n", __func__);
- return -ENODEV;
- }
-
- if (!motg->v3p3 || IS_ERR(motg->v3p3)) {
- pr_err("%s: HSUSB_3p3 is not initialized\n", __func__);
- return -ENODEV;
- }
-
if (on) {
ret = regulator_set_optimum_mode(motg->v1p8,
USB_PHY_1P8_HPM_LOAD);
--
1.7.9.5
next prev parent reply other threads:[~2013-07-09 15:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 15:47 [PATCH v2 0/7] usb: phy: msm: Fixes and cleanups Ivan T. Ivanov
2013-07-09 15:47 ` [PATCH v2 1/7] usb: phy: msm: Move mach depndend code to platform data Ivan T. Ivanov
2013-07-24 12:34 ` Felipe Balbi
2013-07-24 12:36 ` Felipe Balbi
2013-07-09 15:47 ` [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2013-07-24 12:38 ` Felipe Balbi
2013-07-25 13:42 ` Ivan T. Ivanov
2013-07-09 15:47 ` [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation Ivan T. Ivanov
2013-07-24 12:39 ` Felipe Balbi
2013-07-25 13:43 ` Ivan T. Ivanov
2013-07-26 12:31 ` Ivan T. Ivanov
2013-07-26 20:28 ` Felipe Balbi
2013-07-27 6:54 ` Ivan T. Ivanov
2013-07-09 15:47 ` Ivan T. Ivanov [this message]
2013-07-09 15:47 ` [PATCH v2 5/7] usb: phy: msm: Fix WARNING: quoted string split across lines Ivan T. Ivanov
2013-07-09 15:47 ` [PATCH v2 6/7] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf Ivan T. Ivanov
2013-07-09 15:47 ` [PATCH v2 7/7] usb: phy: msm: Lindent the code Ivan T. Ivanov
2013-07-16 11:25 ` [PATCH v2 0/7] usb: phy: msm: Fixes and cleanups Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373384833-18077-5-git-send-email-iivanov@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®