From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549Ab3GIR0v (ORCPT ); Tue, 9 Jul 2013 13:26:51 -0400 Received: from tx2outboundsmtppool2.messaging.microsoft.com ([65.55.83.132]:40464 "EHLO TX2EHSNDR002.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751650Ab3GIR0r convert rfc822-to-8bit (ORCPT ); Tue, 9 Jul 2013 13:26:47 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-FB-OUTBOUND-SPAM: yes X-SpamScore: 3 X-BigFish: VS3(zzc89bhzz1f42h1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6h15abkzz8275bhz2dh87h2a8h668h839h93fhd24he5bhf0ah1239h1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h16a6h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b5bh1d0ch1d2eh1d3fh1dc1h1dfeh1dffh1e1dh1e23h41h42h1151h1155h) X-FB-DOMAIN-IP-MATCH: fail From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= To: , , CC: =?UTF-8?q?Vincent=20Stehl=C3=A9?= , Matt Porter , Sekhar Nori , Vinod Koul , Dan Williams , Russell King Subject: [PATCH linux-next] edma: select arch common code to fix link Date: Tue, 9 Jul 2013 18:49:20 +0200 Message-ID: <1373388560-5129-1-git-send-email-vincent.stehle@freescale.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Reply-To: X-OriginatorOrg: sigmatel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EDMA code has been moved to a common folder with a new CONFIG_TI_PRIV_EDMA switch. Select it when the edma driver is enabled. This fixes the following link error: drivers/built-in.o: In function `edma_remove': of_iommu.c:(.text+0x4ef20): undefined reference to `edma_free_slot' drivers/built-in.o: In function `edma_control': of_iommu.c:(.text+0x4ef70): undefined reference to `edma_stop' drivers/built-in.o: In function `edma_execute': of_iommu.c:(.text+0x4f11c): undefined reference to `edma_write_slot' of_iommu.c:(.text+0x4f150): undefined reference to `edma_link' of_iommu.c:(.text+0x4f168): undefined reference to `edma_start' drivers/built-in.o: In function `edma_free_chan_resources': of_iommu.c:(.text+0x4f220): undefined reference to `edma_stop' of_iommu.c:(.text+0x4f304): undefined reference to `edma_free_slot' of_iommu.c:(.text+0x4f328): undefined reference to `edma_free_channel' drivers/built-in.o: In function `edma_alloc_chan_resources': of_iommu.c:(.text+0x4f37c): undefined reference to `edma_alloc_channel' of_iommu.c:(.text+0x4f3d8): undefined reference to `edma_free_channel' drivers/built-in.o: In function `edma_prep_slave_sg': of_iommu.c:(.text+0x4f67c): undefined reference to `edma_alloc_slot' drivers/built-in.o: In function `edma_probe': of_iommu.c:(.text+0x4f794): undefined reference to `edma_alloc_slot' of_iommu.c:(.text+0x4f8b8): undefined reference to `edma_free_slot' drivers/built-in.o: In function `edma_callback': of_iommu.c:(.text+0x4fae4): undefined reference to `edma_stop' make: *** [vmlinux] Error 1 Signed-off-by: Vincent Stehlé Cc: Matt Porter Cc: Sekhar Nori Cc: Vinod Koul Cc: Dan Williams Cc: Russell King --- Hi, Build of linux next-20130709 is broken for ARM multi_v7_defconfig. This patch fixes it. (Note: the error messages mentioning of_iommu.c are misleading.) Best regards, V. drivers/dma/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 6825957..8b3fca9 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -198,6 +198,7 @@ config TI_EDMA depends on ARCH_DAVINCI || ARCH_OMAP select DMA_ENGINE select DMA_VIRTUAL_CHANNELS + select TI_PRIV_EDMA default n help Enable support for the TI EDMA controller. This DMA -- 1.7.10.4