From: Paul Bolle <pebolle@tiscali.nl>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Borislav Petkov <bp@alien8.de>, Matt Wilson <msw@amazon.com>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
jeremy@goop.org, xen-devel@lists.xensource.com, x86@kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, mingo@redhat.com,
tglx@linutronix.de
Subject: Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter
Date: Thu, 11 Jul 2013 20:13:58 +0200 [thread overview]
Message-ID: <1373566438.1349.21.camel@x61.thuisdomein> (raw)
In-Reply-To: <51DEF1F3.2020900@zytor.com>
On Thu, 2013-07-11 at 10:57 -0700, H. Peter Anvin wrote:
> On 07/11/2013 03:08 AM, Paul Bolle wrote:
> > But the Kconfig entry for XEN_PRIVILEGED_GUEST reads:
> > # Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
> > # name in tools.
> > config XEN_PRIVILEGED_GUEST
> > def_bool XEN_DOM0
> >
> > In other words: CONFIG_XEN_PRIVILEGED_GUEST should always be equal to
> > CONFIG_XEN_DOM0. So the two grep commands should always both evaluate to
> > true or both evaluate to false. One of these two commands can safely be
> > dropped.
>
> Not necessarily true across kernel versions.
Correct. But it has actually been true ever since this Kconfig entry was
introduced in v2.6.37 (commit 6b0661a5e6fbfb159b78a39c0476905aa9b575fe,
"xen: introduce XEN_DOM0 as a silent option").
So people need not worry about breaking grub2 by dropping
XEN_PRIVILEGED_GUEST.
Paul Bolle
next prev parent reply other threads:[~2013-07-11 18:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 6:28 Michael Opdenacker
2013-07-08 19:28 ` Konrad Rzeszutek Wilk
2013-07-08 19:34 ` [Xen-devel] " Matt Wilson
2013-07-08 20:29 ` H. Peter Anvin
2013-07-08 20:58 ` Borislav Petkov
2013-07-08 23:35 ` Paul Bolle
2013-07-09 0:26 ` Konrad Rzeszutek Wilk
2013-07-09 7:41 ` Jan Beulich
2013-07-09 14:48 ` Konrad Rzeszutek Wilk
2013-07-09 14:54 ` Jan Beulich
2013-07-09 15:05 ` Borislav Petkov
2013-07-09 15:09 ` H. Peter Anvin
2013-07-09 17:19 ` Konrad Rzeszutek Wilk
2013-07-09 20:01 ` Borislav Petkov
2013-07-09 20:40 ` Konrad Rzeszutek Wilk
2013-07-09 20:57 ` Borislav Petkov
2013-07-09 22:34 ` Sander Eikelenboom
2013-07-10 3:20 ` Borislav Petkov
2013-07-10 3:55 ` H. Peter Anvin
2013-07-10 6:19 ` Matt Wilson
2013-07-10 7:41 ` Sander Eikelenboom
2013-07-10 14:46 ` Konrad Rzeszutek Wilk
2013-07-11 10:08 ` Paul Bolle
2013-07-11 17:57 ` H. Peter Anvin
2013-07-11 18:13 ` Paul Bolle [this message]
2013-07-11 18:24 ` Konrad Rzeszutek Wilk
2013-07-11 21:13 ` Geert Uytterhoeven
2013-07-08 20:13 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373566438.1349.21.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=mingo@redhat.com \
--cc=msw@amazon.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®