From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463Ab3GNNSU (ORCPT ); Sun, 14 Jul 2013 09:18:20 -0400 Received: from cpsmtpb-ews10.kpnxchange.com ([213.75.39.15]:59481 "EHLO cpsmtpb-ews10.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325Ab3GNNST (ORCPT ); Sun, 14 Jul 2013 09:18:19 -0400 Message-ID: <1373807896.1370.43.camel@x61.thuisdomein> Subject: Re: [PATCH] ARM: EXYNOS: remove references to non-DT SoCs From: Paul Bolle To: Mark Brown Cc: Ben Dooks , Kukjin Kim , Sangbeom Kim , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Sun, 14 Jul 2013 15:18:16 +0200 In-Reply-To: <20130714124538.GA11538@sirena.org.uk> References: <1373804812.1370.23.camel@x61.thuisdomein> <20130714124538.GA11538@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Jul 2013 13:18:16.0823 (UTC) FILETIME=[9A0AB070:01CE8094] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2013-07-14 at 13:45 +0100, Mark Brown wrote: > Look at the code you are editing here: > > > - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210) > > + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110) > > Simply removing the dependencies is not going to give the clearly > intended effect here. The dependency on the DT only machine needs to be > replaced with something, not just deleted, otherwise the driver can't be > enabled in Kconfig. I interpreted commit 383ffda2fa as a commit that just removed a lot of stuff: see its commit explanation and its diffstat (it adds one line and deletes over 900 lines). Moreover, after that commit the references to MACH_SMDKV310 and MACH_SMDKC210 both are nops. Deleting them can't possibly change anything. But, anyhow, what would be the symbols to use here? > Also let me again remind you to submit patches with subject lines that > are appropriate for the subsystem you're updating. I very nearly > deleted this unread since it looks like a patch for arch/arm with no > relationship with audio but in fact it doesn't touch arch/arm at all. I do try to use subject lines that are used in the sections I touch. I seem to remember that you asked me _once_, I think one or two years ago, to adjust to the system used for SoC. Since then you've received a number of patches from me that, as far as I can remember, always used that system. Besides, this patch was intended as a follow up to commit 383ffda2fa, to clean up two references it apparently forgot to remove, and therefor basically copied the subject line used in that commit. Paul Bolle