From: Joe Perches <joe@perches.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH-v2 06/17] staging/lustre: remove HIPQUAD
Date: Mon, 15 Jul 2013 06:38:49 -0700 [thread overview]
Message-ID: <1373895529.2062.15.camel@joe-AO722> (raw)
In-Reply-To: <1373893695-4094-7-git-send-email-bergwolf@gmail.com>
On Mon, 2013-07-15 at 21:08 +0800, Peng Tao wrote:
[]
> We should just remove HIPQUAD and replace it with %pI4.
HIPQUAD and NIPQUAD were host and network order variants.
Perhaps you need %pI4h for the host uses?
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
[]
> @@ -2574,8 +2574,8 @@ kiblnd_dev_need_failover(kib_dev_t *dev)
> rc = rdma_resolve_addr(cmid, (struct sockaddr *)&srcaddr,
> (struct sockaddr *)&dstaddr, 1);
> if (rc != 0 || cmid->device == NULL) {
> - CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
> - dev->ibd_ifname, HIPQUAD(dev->ibd_ifip),
> + CERROR("Failed to bind %s:%pI4 to device(%p): %d\n",
> + dev->ibd_ifname, &dev->ibd_ifip,
> cmid->device, rc);
Like this one?
next prev parent reply other threads:[~2013-07-15 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 13:07 [PATCH-v2 00/17] staging/lustre: fix various build issues Peng Tao
2013-07-15 13:07 ` [PATCH-v2 01/17] staging/lustre: replace num_physpages with totalram_pages Peng Tao
2013-07-15 13:08 ` [PATCH-v2 02/17] staging/lustre: fix Lustre code link order Peng Tao
2013-07-15 13:08 ` [PATCH-v2 03/17] staging/lustre: don't assert module owner Peng Tao
2013-07-15 13:08 ` [PATCH-v2 04/17] staging/lustre: don't assert ln_refcount in LNetGetId Peng Tao
2013-07-15 13:08 ` [PATCH-v2 05/17] stating/lustre: only build if configured as module Peng Tao
2013-07-15 13:08 ` [PATCH-v2 06/17] staging/lustre: remove HIPQUAD Peng Tao
2013-07-15 13:38 ` Joe Perches [this message]
2013-07-15 14:08 ` Peng Tao
2013-07-15 13:08 ` [PATCH-v2 07/17] staging/lustre: fix build error when !CONFIG_SMP Peng Tao
2013-07-15 13:08 ` [PATCH-v2 08/17] staging/lustre: fix build on s390 Peng Tao
2013-07-15 13:08 ` [PATCH-v2 09/17] staging/lustre/llite: add missing include file for prefetchw Peng Tao
2013-07-15 13:08 ` [PATCH-v2 10/17] staging/lustre/llite: fix build erorr if CONFIG_FS_POSIX_ACL is off Peng Tao
2013-07-15 13:08 ` [PATCH-v2 11/17] staging/lustre: fix build when CONFIG_UIDGID_STRICT_TYPE_CHECKS is on Peng Tao
2013-07-15 13:08 ` [PATCH-v2 12/17] staging/lustre: fix build error on non-x86 platforms Peng Tao
2013-07-15 13:08 ` [PATCH-v2 13/17] staging/lustre: fix build warnning on 32bit system Peng Tao
2013-07-15 13:08 ` [PATCH-v2 14/17] staging/lustre: fix for invalidatepage() API change Peng Tao
2013-07-15 13:08 ` [PATCH-v2 15/17] staging/lustre/llite: fix for d_compare " Peng Tao
2013-07-15 13:08 ` [PATCH-v2 16/17] staging/lustre/llite: readdir convert to iterate Peng Tao
2013-07-15 13:08 ` [PATCH-v2 17/17] staging/lustre: drop CONFIG_BROKEN Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373895529.2062.15.camel@joe-AO722 \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®