From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Jones <davej@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: nohz: Warn if the machine can not perform nohz_full
Date: Mon, 15 Jul 2013 15:30:20 -0400 [thread overview]
Message-ID: <1373916620.17876.182.camel@gandalf.local.home> (raw)
In-Reply-To: <20130715185624.GB1706@redhat.com>
On Mon, 2013-07-15 at 14:56 -0400, Dave Jones wrote:
> On Mon, Jul 15, 2013 at 02:49:42PM -0400, Steven Rostedt wrote:
>
> Is a printk not enough for that purpose ? Tainting the kernel is kinda anti-social.
>
printk's don't usually get peoples attention. Taints and warnings do. If
the hardware doesn't allow for nohz-full, and the only way to enable it
is via kernel command line, how do you scream to the user that it isn't
going to work.
We could do a large banner saying:
***************************************************************
***************************************************************
***************************************************************
***************************************************************
*** UNSTABLE TSC ***
*** NO_HZ_FULL disabled ***
***************************************************************
***************************************************************
***************************************************************
***************************************************************
And not do the warning. Maybe that will get peoples attentions?
But then again, this could be lost in the boot up if the box prints a
lot of data.
-- Steve
next prev parent reply other threads:[~2013-07-15 19:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 17:08 Dave Jones
2013-07-15 17:18 ` Frederic Weisbecker
2013-07-15 17:24 ` Dave Jones
2013-07-15 17:38 ` Dave Jones
2013-07-15 18:49 ` Steven Rostedt
2013-07-15 18:56 ` Dave Jones
2013-07-15 19:30 ` Steven Rostedt [this message]
2013-07-16 1:10 ` Frederic Weisbecker
2013-07-16 1:05 ` Frederic Weisbecker
2013-07-16 14:22 ` [PATCH] nohz: Do not warn about unstable tsc unless user uses nohz_full Steven Rostedt
2013-07-16 16:12 ` Frederic Weisbecker
2013-07-16 1:03 ` nohz: Warn if the machine can not perform nohz_full Frederic Weisbecker
2013-07-16 1:01 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373916620.17876.182.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=davej@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®