From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933165Ab3GPP3u (ORCPT ); Tue, 16 Jul 2013 11:29:50 -0400 Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:50118 "EHLO cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932241Ab3GPP3t (ORCPT ); Tue, 16 Jul 2013 11:29:49 -0400 Message-ID: <1373988586.17662.4.camel@x61.thuisdomein> Subject: Re: [PATCH v2] [SCSI] scsi_debug: silence GCC warning From: Paul Bolle To: Akinobu Mita Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, LKML , "Martin K. Petersen" , Douglas Gilbert Date: Tue, 16 Jul 2013 17:29:46 +0200 In-Reply-To: References: <1373879920.2591.13.camel@x61.thuisdomein> <1373914081.2591.40.camel@x61.thuisdomein> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 Jul 2013 15:29:47.0261 (UTC) FILETIME=[4DEF7AD0:01CE8239] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote: > This one looks good to me. Thanks. > It would be much better if this commit > log had a reference to the commit that introduced this warning as > you described after '---' in v1 patch. Do you mean that I should submit a v3, with a commit explanation that also has one or two lines that mention commit beb40ea42b ("[SCSI] scsi_debug: reduce duplication between prot_verify_read and prot_verify_write")? Paul Bolle