From: "Martin J. Bligh" <mbligh@aracnet.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [Bug 415] New: aty128fb.c fails to compile (logic error)
Date: Wed, 26 Feb 2003 17:41:46 -0800 [thread overview]
Message-ID: <13740000.1046310106@[10.10.2.4]> (raw)
http://bugme.osdl.org/show_bug.cgi?id=415
Summary: aty128fb.c fails to compile (logic error)
Kernel Version: 2.5.63
Status: NEW
Severity: normal
Owner: bugme-janitors@lists.osdl.org
Submitter: donaldlf@i-55.com
Distribution:rawhide
Hardware Environment: LX164/alpha
Software Environment: redhat
Problem Description:
the driver aty128fb.c aka DRI for ATI Rage pro fails to compile
due to logic error in aty128fb_setup there are 3 #define cases each
is for mac, intel , or ppc. there is an 4th case for default purposes.
The logic is constructed so that it's an if else logic tree, find a good
case short circuit around the rest. The problem is if one of the three
conditions don't apply then there is an else with no if. I restructured
the code so now it uses continues. Same speed fewer indentions and
it will now compile.
patch will be include in followup.
Steps to reproduce:
select XFree 4.1 DRI modules.
select an non PPC no Intel hardware
select ATI Rage 128 DRI driver
compile.
reply other threads:[~2003-02-27 1:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='13740000.1046310106@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®