From: Paul Bolle <pebolle@tiscali.nl>
To: Martin Walch <walch.martin@web.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [kconfig] results of some syntactical checks
Date: Wed, 17 Jul 2013 08:30:58 +0200 [thread overview]
Message-ID: <1374042658.26384.31.camel@x61.thuisdomein> (raw)
In-Reply-To: <1374016680.26384.22.camel@x61.thuisdomein>
On Wed, 2013-07-17 at 01:18 +0200, Paul Bolle wrote:
> On Wed, 2013-07-17 at 00:34 +0200, Martin Walch wrote:
> > Symbol: M at
> > drivers/usb/host/Kconfig:568:0
> > drivers/usb/misc/Kconfig:130:0
>
> This looks odd. I think your checker doesn't like an uppercase M after
> default. There are exactly two of those in the tree.
After posting this I actually looked into this and even tested it a bit.
It turns out an uppercase 'M' isn't a valid alias for the magic 'm'
value. Your checker is right about warning for this.
> > Symbol: N at
> > drivers/usb/core/Kconfig:12:0
> > drivers/usb/host/Kconfig:336:0
> > drivers/usb/host/Kconfig:348:0
> > drivers/staging/usbip/Kconfig:3:0
> > drivers/staging/usbip/Kconfig:20:0
> > drivers/staging/usbip/Kconfig:31:0
> > drivers/staging/usbip/Kconfig:42:0
> > drivers/staging/asus_oled/Kconfig:3:0
> > drivers/staging/rtl8187se/Kconfig:8:0
> > drivers/staging/rtl8192u/Kconfig:7:0
> > drivers/staging/rtl8192e/rtl8192e/Kconfig:7:0
> > drivers/staging/rtl8712/Kconfig:6:0
> > drivers/staging/rtl8712/Kconfig:14:0
> > drivers/staging/frontier/Kconfig:3:0
> > drivers/staging/bcm/Kconfig:3:0
> > drivers/staging/media/go7007/Kconfig:15:0
> > drivers/staging/media/go7007/Kconfig:26:0
> > drivers/staging/media/go7007/Kconfig:48:0
> > drivers/staging/android/Kconfig:4:0
> > drivers/staging/android/Kconfig:61:0
> > arch/cris/arch-v32/drivers/Kconfig:13:0
> > arch/cris/arch-v32/drivers/Kconfig:413:0
> > arch/arc/Kconfig:357:0
>
> Ditto (but I haven't actually counted the occurrences of "default N").
Lowercase 'n' is the correct magic value. But using uppercase 'N'
doesn't matter. Since there's no Kconfig symbol "N", both evaluate to
"not set" and you'll end up with the same .config file.
> My script currently finds 28 undefined symbols. That equals this result
> (given you have 2 false positive and 1 undefined choice default.)
So those 2 were actually correct positives.
Paul Bolle
next prev parent reply other threads:[~2013-07-17 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 22:34 Martin Walch
2013-07-16 23:18 ` Paul Bolle
2013-07-17 6:30 ` Paul Bolle [this message]
2013-07-17 13:07 ` Martin Walch
2013-07-18 12:17 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374042658.26384.31.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=walch.martin@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®