From: Qiaowei Ren <qiaowei.ren@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Gang Wei <gang.wei@intel.com>,
Qiaowei Ren <qiaowei.ren@intel.com>
Subject: [PATCH v5] x86, tboot: iomem fixes
Date: Sun, 21 Jul 2013 00:26:52 +0800 [thread overview]
Message-ID: <1374337612-6899-1-git-send-email-qiaowei.ren@intel.com> (raw)
Current code doesn't use specific interface to access I/O space.
So some potential bugs can be caused. We can fix this by using
specific API.
Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
---
arch/x86/kernel/tboot.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
index 3ff42d2..4e149c7 100644
--- a/arch/x86/kernel/tboot.c
+++ b/arch/x86/kernel/tboot.c
@@ -468,7 +468,8 @@ struct sinit_mle_data {
struct acpi_table_header *tboot_get_dmar_table(struct acpi_table_header *dmar_tbl)
{
- void *heap_base, *heap_ptr, *config;
+ void __iomem *heap_base, *heap_ptr, *config;
+ u32 dmar_tbl_off;
if (!tboot_enabled())
return dmar_tbl;
@@ -485,25 +486,26 @@ struct acpi_table_header *tboot_get_dmar_table(struct acpi_table_header *dmar_tb
return NULL;
/* now map TXT heap */
- heap_base = ioremap(*(u64 *)(config + TXTCR_HEAP_BASE),
- *(u64 *)(config + TXTCR_HEAP_SIZE));
+ heap_base = ioremap(readl(config + TXTCR_HEAP_BASE),
+ readl(config + TXTCR_HEAP_SIZE));
iounmap(config);
if (!heap_base)
return NULL;
/* walk heap to SinitMleData */
/* skip BiosData */
- heap_ptr = heap_base + *(u64 *)heap_base;
+ heap_ptr = heap_base + readq(heap_base);
/* skip OsMleData */
- heap_ptr += *(u64 *)heap_ptr;
+ heap_ptr += readq(heap_ptr);
/* skip OsSinitData */
- heap_ptr += *(u64 *)heap_ptr;
+ heap_ptr += readq(heap_ptr);
/* now points to SinitMleDataSize; set to SinitMleData */
heap_ptr += sizeof(u64);
/* get addr of DMAR table */
+ dmar_tbl_off = readl(heap_ptr +
+ offsetof(struct sinit_mle_data, vtd_dmars_off));
dmar_tbl = (struct acpi_table_header *)(heap_ptr +
- ((struct sinit_mle_data *)heap_ptr)->vtd_dmars_off -
- sizeof(u64));
+ dmar_tbl_off - sizeof(u64));
/* don't unmap heap because dmar.c needs access to this */
--
1.7.9.5
next reply other threads:[~2013-07-20 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 16:26 Qiaowei Ren [this message]
2013-07-22 8:50 ` Ingo Molnar
2013-08-06 22:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374337612-6899-1-git-send-email-qiaowei.ren@intel.com \
--to=qiaowei.ren@intel.com \
--cc=gang.wei@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®